[pkg-wpa-devel] r1940 - in /wpa/tags/1.0-3+deb7u2/debian: changelog patches/series patches/wpasupplicant_P2P-Validate-SSID-element-length-before-copying-it-C.patch

[slh-guest at users.alioth.debian.org]

Author: slh-guest
Date: Sun Apr 26 00:55:27 2015
New Revision: 1940

URL: http://svn.debian.org/wsvn/?sc=1&rev=1940
Log:
import "P2P: Validate SSID element length before copying it
(CVE-2015-1863)" from upstream (Closes: #783148); this is essentially a
no-op for the wheezy binaries distributed by Debian, as CONFIG_P2P is
disabled there.

Added:
    wpa/tags/1.0-3+deb7u2/debian/patches/wpasupplicant_P2P-Validate-SSID-element-length-before-copying-it-C.patch
Modified:
    wpa/tags/1.0-3+deb7u2/debian/changelog
    wpa/tags/1.0-3+deb7u2/debian/patches/series

Modified: wpa/tags/1.0-3+deb7u2/debian/changelog
URL: http://svn.debian.org/wsvn/wpa/tags/1.0-3%2Bdeb7u2/debian/changelog?rev=1940&op=diff
==============================================================================
--- wpa/tags/1.0-3+deb7u2/debian/changelog	(original)
+++ wpa/tags/1.0-3+deb7u2/debian/changelog	Sun Apr 26 00:55:27 2015
@@ -1,3 +1,12 @@
+wpa (1.0-3+deb7u2) wheezy-security; urgency=high
+
+  * import "P2P: Validate SSID element length before copying it
+    (CVE-2015-1863)" from upstream (Closes: #783148); this is essentially a
+    no-op for the wheezy binaries distributed by Debian, as CONFIG_P2P is
+    disabled there.
+
+ -- Stefan Lippers-Hollmann <s.l-h at gmx.de>  Thu, 23 Apr 2015 19:56:11 +0200
+
 wpa (1.0-3+deb7u1) wheezy-security; urgency=high
 
   * Apply upstream patches for CVE-2014-3686 (Closes: #765352):

Modified: wpa/tags/1.0-3+deb7u2/debian/patches/series
URL: http://svn.debian.org/wsvn/wpa/tags/1.0-3%2Bdeb7u2/debian/patches/series?rev=1940&op=diff
==============================================================================
--- wpa/tags/1.0-3+deb7u2/debian/patches/series	(original)
+++ wpa/tags/1.0-3+deb7u2/debian/patches/series	Sun Apr 26 00:55:27 2015
@@ -10,3 +10,4 @@
 CVE-2014-3686/0001-Add-os_exec-helper-to-run-external-programs.patch
 CVE-2014-3686/0002-wpa_cli-Use-os_exec-for-action-script-execution.patch
 CVE-2014-3686/0003-hostapd_cli-Use-os_exec-for-action-script-execution.patch
+wpasupplicant_P2P-Validate-SSID-element-length-before-copying-it-C.patch

Added: wpa/tags/1.0-3+deb7u2/debian/patches/wpasupplicant_P2P-Validate-SSID-element-length-before-copying-it-C.patch
URL: http://svn.debian.org/wsvn/wpa/tags/1.0-3%2Bdeb7u2/debian/patches/wpasupplicant_P2P-Validate-SSID-element-length-before-copying-it-C.patch?rev=1940&op=file
==============================================================================
--- wpa/tags/1.0-3+deb7u2/debian/patches/wpasupplicant_P2P-Validate-SSID-element-length-before-copying-it-C.patch	(added)
+++ wpa/tags/1.0-3+deb7u2/debian/patches/wpasupplicant_P2P-Validate-SSID-element-length-before-copying-it-C.patch	Sun Apr 26 00:55:27 2015
@@ -0,0 +1,37 @@
+From 9ed4eee345f85e3025c33c6e20aa25696e341ccd Mon Sep 17 00:00:00 2001
+From: Jouni Malinen <jouni at qca.qualcomm.com>
+Date: Tue, 7 Apr 2015 11:32:11 +0300
+Subject: [PATCH] P2P: Validate SSID element length before copying it
+ (CVE-2015-1863)
+
+This fixes a possible memcpy overflow for P2P dev->oper_ssid in
+p2p_add_device(). The length provided by the peer device (0..255 bytes)
+was used without proper bounds checking and that could have resulted in
+arbitrary data of up to 223 bytes being written beyond the end of the
+dev->oper_ssid[] array (of which about 150 bytes would be beyond the
+heap allocation) when processing a corrupted management frame for P2P
+peer discovery purposes.
+
+This could result in corrupted state in heap, unexpected program
+behavior due to corrupted P2P peer device information, denial of service
+due to process crash, exposure of memory contents during GO Negotiation,
+and potentially arbitrary code execution.
+
+Thanks to Google security team for reporting this issue and smart
+hardware research group of Alibaba security team for discovering it.
+
+Signed-off-by: Jouni Malinen <jouni at qca.qualcomm.com>
+---
+ src/p2p/p2p.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/src/p2p/p2p.c
++++ b/src/p2p/p2p.c
+@@ -612,6 +612,7 @@ int p2p_add_device(struct p2p_data *p2p,
+ 	if (os_memcmp(addr, p2p_dev_addr, ETH_ALEN) != 0)
+ 		os_memcpy(dev->interface_addr, addr, ETH_ALEN);
+ 	if (msg.ssid &&
++	    msg.ssid[1] <= sizeof(dev->oper_ssid) &&
+ 	    (msg.ssid[1] != P2P_WILDCARD_SSID_LEN ||
+ 	     os_memcmp(msg.ssid + 2, P2P_WILDCARD_SSID, P2P_WILDCARD_SSID_LEN)
+ 	     != 0)) {