[pkg-wpa-devel] Bug#780552: Bug#780552: wpa_supplicant.service needs Before=network.target to ensure proper ordering on shutdown
Stefan Lippers-Hollmann
s.l-h at gmx.de
Tue Mar 17 04:43:14 UTC 2015
Hi
On 2015-03-17, Michael Biebl wrote:
[...]
> Am 17.03.2015 um 03:51 schrieb Stefan Lippers-Hollmann:
[...]
> > Looking at it more thoroughly, I think "After=syslog.target" might be
> > needed as well, given that (by default) wpa_supplicant uses the syslog
> > facilities for logging purposes. Therefore I'd suggest this patch
> > instead:
>
> After=syslog.target is not necessary, it will actually generate a
> lintian warning, since using that is deprecated.
> sysloggers are socket activated nowadays, so don't need an explicit
> dependency.
[...]
Thanks for clearing this up, I'll therefore drop (well not commit in
the first place) the "After=syslog.target" addition.
> > Given the current stage of the freeze[1], would you like to get this
> > uploaded for jessie? In that case I'll coordinate with release and d-i
> > teams after the upload to unstable, pending release and udeb unblock, it
> > should migrate without problems.
>
> Good question. I think the combination of wireless + remote FS (like
> NFS) is not that common that we must need to get this into jessie.
Fixed (as in fstab/ auto) nfs shares (or similar remote filesystem
mounts, which don't cope well with shorter or longer service disruptions)
over wlan are not a good idea - and outright insane for system
mountpoints like / or /usr/. Mounting remote filesystems temporarily
at runtime might be more acceptable though (but I'd strongly suggest to
use userspace mounting, like KDE's kio-slaves, probably gvfs or autofs
mounts, perhaps even fuse based filesystems, for unreliable links
instead, something that doesn't lock up hard whenever the network link
stalls).
> If you plan another upload though, I would probably squeeze that one in
> since it has pretty low regression potential.
There are two pending changes beyond this, but imho neither meet the unblock
criterias at this stage.
- dropping Kel from Uploaders (upon his request, certainly not warranting
an unblock, but this should be acceptable to the release team in
combination with a real bugfix meeting the criterias).
- fixing a segfault when using hostapd for a non-wireless (ethernet)
interface (this is not exploitable, hostapd will just hard-fail to start
using a config file configuring driver=wired). Technically I'd consider
this to be RC, but given how rare using IEEE 8021X on wired ethernet
networks is in practice - especially on Debian compatible hardware
(rather than using commercial/ managed ethernet switches) - I don't think
this would warrant a freeze exemption (this bug has not been reported to
the Debian BTS). The bugfix[1] itself should be self-contained enough and
probably acceptable to the release team (not affecting the feature set
chosen for wpasupplicant-udeb).
A more important bugfix would be backporting a patch for using AP mode
wlan interfaces bridged with ethernet ones[2], however this hasn't been
reported to the Debian BTS either and would be far too invasive to touch
at this point - especially as this would need further patches (and larger
backporting) to make it compile on top of wpa 2.3. I don't feel
comfortable with pushing this particular fix to jessie at the moment (and
haven't completed the actual backporting yet either), especially as no
other distribution is shipping this (or wpa 2.4, containing it) yet (except
for OpenWrt, which doesn't technically ship this patch either, but fixes
the kernel regression in a non-upstreamable way instead).
All of these bugs are fixed upstream for wpa 2.4 (released just last
sunday) and will be ready for stretch just after jessie has been released.
Nevertheless I have prepared these packages (without [1]), containing only
the "Before=network.target" change and dropping Kel from Uploaders, if
you'd like to upload this for jessie
dget -ud http://aptosid.com/slh/wpa/wpa_2.3-2.dsc
http://aptosid.com/slh/wpa/wpa_2.3-2.debian.tar.xz
http://aptosid.com/slh/wpa/wpa_2.3.orig.tar.xz
### snip ###
diff -Nru wpa-2.3/debian/changelog wpa-2.3/debian/changelog
--- wpa-2.3/debian/changelog 2014-10-14 21:30:29.000000000 +0200
+++ wpa-2.3/debian/changelog 2015-03-17 02:24:32.000000000 +0100
@@ -1,3 +1,13 @@
+wpa (2.3-2) unstable; urgency=medium
+
+ * remove Kel Modderman from Uploaders as per his request, many thanks for
+ all past efforts Kel.
+ * fix systemd unit dependencies for wpasupplicant, it needs to be started
+ before the network target (Closes: 780552), many thanks to Michael Biebl
+ <biebl at debian.org> for reporting and suggesting the patch.
+
+ -- Stefan Lippers-Hollmann <s.l-h at gmx.de> Tue, 17 Mar 2015 02:23:24 +0100
+
wpa (2.3-1) unstable; urgency=medium
* New upstream release:
diff -Nru wpa-2.3/debian/control wpa-2.3/debian/control
--- wpa-2.3/debian/control 2014-09-18 06:28:20.000000000 +0200
+++ wpa-2.3/debian/control 2015-03-17 00:59:27.000000000 +0100
@@ -1,7 +1,6 @@
Source: wpa
Maintainer: Debian wpasupplicant Maintainers <pkg-wpa-devel at lists.alioth.debian.org>
-Uploaders: Kel Modderman <kel at otaku42.de>,
- Stefan Lippers-Hollmann <s.l-h at gmx.de>,
+Uploaders: Stefan Lippers-Hollmann <s.l-h at gmx.de>,
Jan Dittberner <jandd at debian.org>
Section: net
Priority: optional
diff -Nru wpa-2.3/debian/patches/series wpa-2.3/debian/patches/series
--- wpa-2.3/debian/patches/series 2014-10-14 21:30:29.000000000 +0200
+++ wpa-2.3/debian/patches/series 2015-03-17 01:08:26.000000000 +0100
@@ -6,3 +6,4 @@
wpa_gui_desktop_add-keywords-entry.patch
wpa_supplicant-MACsec-fix-build-failure-for-IEEE8021.patch
include-ieee802_11_common.c-in-wpa_supplicant-build-.patch
+wpasupplicant_fix-systemd-unit-dependencies.patch
diff -Nru wpa-2.3/debian/patches/wpasupplicant_fix-systemd-unit-dependencies.patch wpa-2.3/debian/patches/wpasupplicant_fix-systemd-unit-dependencies.patch
--- wpa-2.3/debian/patches/wpasupplicant_fix-systemd-unit-dependencies.patch 1970-01-01 01:00:00.000000000 +0100
+++ wpa-2.3/debian/patches/wpasupplicant_fix-systemd-unit-dependencies.patch 2015-03-17 01:19:50.000000000 +0100
@@ -0,0 +1,20 @@
+wpasupplicant: fix systemd unit dependencies
+
+wpasupplicant needs to be started before the network target
+(Closes: 780552).
+
+Debian bug: https://bugs.debian.org/780552
+Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769186#41
+systemd upstream bug: https://bugs.freedesktop.org/show_bug.cgi?id=86707#c3
+
+Signed-off-by: Stefan Lippers-Hollmann <s.l-h at gmx.de>
+
+--- a/wpa_supplicant/systemd/wpa_supplicant.service.in
++++ b/wpa_supplicant/systemd/wpa_supplicant.service.in
+@@ -1,5 +1,6 @@
+ [Unit]
+ Description=WPA supplicant
++Before=network.target
+
+ [Service]
+ Type=dbus
### snip ###
These packages have been build-tested on {amd64,i386,armhf,arm64}[3]
and kfreebsd-amd64[4], as well as been given a quick test for ath5k and
ipw2200 on i386. I still don't really think it's warranted to push this
for jessie, but would be fine with following this up with release- and
d-i teams, respectively ask them for pre-approval (with or without[1]),
which would probably be the best course of action.
Regards
Stefan Lippers-Hollmann
[1] hostapd: Verify VHT 160/80+80 MHz driver support
http://w1.fi/cgit/hostap/commit/?id=7f0303d5b0bb425f3e7318a7016b55ba9e67f9de
[2] Work around Linux packet socket regression
http://w1.fi/cgit/hostap/commit/?id=e6dd8196e5daf39e4204ef8ecd26dd50fdca6040
[3] http://aptosid.com/slh/wpa/_build.log
[4] http://aptosid.com/slh/wpa/wpa_2.3-2_kfreebsd-amd64.build
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.alioth.debian.org/pipermail/pkg-wpa-devel/attachments/20150317/435552e9/attachment.sig>
More information about the Pkg-wpa-devel
mailing list