[Pkg-x2go-devel] NX Packages built from nx-libs.git on X2Go Git now lintian-clean

[Reinhard Tartler]

On Do, Dez 29, 2011 at 21:57:43 (CET), Mike Gabriel wrote:

> Hi all (esp. Reinhard),
>
> today I have upgraded/reworked/fixed nx-libs.git on git.x2go.org with
> these results/steps:
>
>   o updated nxagent to 3.5.0-7
>   o all upstream source tarballs have been checked in with the pristine-tar
>     branch
>   o nxagent now works with FreeNX as available on Ubuntu Launchpad
> (freenx-team)
>   o all FreeNX patches have been integrated
>   o source and binary packages are now Lintian clean

TBH, I think (almost) all lintian warnings should rather be fixed than
supressed.

>
> I guess it now is time for others to take a closer look at the code  and
> esp. the patch series. Reinhard could you take some time to do  that?

I'm a bit surprised to see that you are asking on this mailing list for
review for a branch on git.x2go.org, and not one on alioth. I assume you
want to use that branch both as upstream and as packaging branch at the
same time? This was not what I had in mind when I proposed the layout of
the x2go branches. In particular, I don't have the impression that all
x2go developers are comfortable with working on quilt series. Maybe this
changed without me noticing it? - In any case, I think the requirement
of solid command of git raises the bar to hack on the sources
considerably.


> Other contributors of feedback are really welcome.
>
> Open issues still are:
>
>   o no common debian/watch file yet that checks all sub-tarballs that nx-libs
>     draws in from NoMachine upstream

Uh? I thought x2go was upstream for Debian, not Nomachine?

>   o no get-orig-source stanza in debian/rules, this is highly recommended

*shrug*, I don't care much here. I'd consider a working watch file more
important.

>   o I have a working xinerama patch for nxagent/x2goagent pending that also
>     shall find its way into nx-libs.git

noted.

What occurs to me after a rather brief look:

 - I don't believe that debian/copyright is complete

 - nx-X11/extras contains a lot of duplicated libraries that are already
   in debian. I'm not convinced that all of them are really needed. In
   any case, I fear they'd all need to be documented in debian/copyright

 - For the debian packages, the maintainer field must point to the team,
   not oleksandr. For the upstream code, this is fine.

 - The Homepage field should point to the x2go homepage. The origin of
   the sources has to be documented in debian/copyright, not in
   debian/control

 - debian/control contains a commented out package. Remove it or enable
   it. don't leave them commented out, that's pointless.

 - The description of the package libnx-x11 is too terse. Other
   description could also be improved

 - debian/changelog needs to close an ITP bug.

 - 001_add-main-makefile.patch is pointless. Just place the makefile in
   debian/

 - most (all?) patches in debian/patches lack a patch documentation
   header, see http://dep.debian.net/deps/dep3/

 - patch 006_remove-configure-files.patch is pointless, just remove the
   file in debian/rules in the clean target

 - 008_nxproxy_add-nxproxy-wrapper.patch is pointless, just place the
   wrapper in some subfolder in debian/

 - same for 009_nxproxy_add-man-page.patch, and many others as well.


I have to stop now. I think you got the basic idea of what I've looked
for in this run. Yes, I think there is still a *lot* of work left before
we can upload nx-libs to Debian¹.

Cheers,
Reinhard


1: Which is another reason why I was against the 'nx-libs.git'
approach. Btw, did you find out in the end what the problem actually was?


-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4