[Pkg-x2go-devel] NX Packages built from nx-libs.git on X2Go Git now lintian-clean

[Mike Gabriel]

Hi Reinhard,

On Fr 30 Dez 2011 21:15:35 CET Reinhard Tartler wrote:

> On Fr, Dez 30, 2011 at 12:01:02 (CET), Mike Gabriel wrote:
>
>> Hi Reinhard,
>>
>> On Fr 30 Dez 2011 00:12:10 CET Reinhard Tartler wrote:
>>
>>> On Do, Dez 29, 2011 at 21:57:43 (CET), Mike Gabriel wrote:

>> 1. possible-new-upstream-release-without-new-version
>> -> a new upstream release of any of the NX component does not mean that we
>>    use a new version number... nonetheless in the changelog there should be
>>    a message: New upstream release of <NX-component> (<version>).
>>
>> 2. postinst-has-useless-call-to-ldconfig and
>> postrm-has-useless-call-to-ldconfig
>>    relate to a bug in debhelper... -> #205142
>>
>> 3. ancient-autotools-helper-file, outdated-autotools-helper-file, ancient-
>>    libtool are all fixed via the patch system (by patching in  
>> stable versions
>>    of config.guess, config.sub, ltmain.sh). However, these patches to not
>>    appear in the source tarball an so the warnings/errors are still  
>> reported.

1.-3. are wontfixes...

>> 4. breaks-without-version -> I could check what version is needed here to
>>    definitely make sure to replace nxcomp* with libxcomp*3.
>>    So this one is on my TODO!

4. is fixed

> Well, if you are aware that they still need work, then rather fix them
> instead of suppressing (== adding lintian overrides). Claiming the
> package was 'lintian-clean' is just so wrong when it isn't.


>> I will push the whole repos to Alioth, if agreed. The location on
>> git.x2go.org currently is for convenience as it integrates with our
>> Debian and Ubuntu build system. Consider it as lazyness for now.
>
> Noted. I will keep that in mind for the future.

The Git on Alioth and on X2Go are now clones of each other. My  
suggestion is to work on the Alioth Git and sync regularly/manually to  
the X2Go repos for package building.

>> Since NoMachine has become active again about NX (they have released
>> nxagent 3.5.0-7 since we had set up the new nx-libs.git repos) I do  not
>> consider the X2Go project as upstream anymore.
>
> Aha. Well, while I'm not convinced (yet?) that this was a good idea,
> such pieces of information really should go into README.source. Besides,
> currently the file exists but its contents are a joke, maybe you added
> it only because lintian started to complain?

Ok, being more verbose on that now in README.source.
http://anonscm.debian.org/gitweb/?p=collab-maint/x2go/nx-libs.git;a=commitdiff;h=caa6dd5f1a0f503379095bb69708f0c47a43ec80

>> So nx-libs.git is considered as a packaging only repos which draws in
>> a couple of patches that should also be reported upstream.
>
> Yeah, that's how the branch currently looks like. Still, I'm not
> convinced that this approach makes it easy to hack on for x2go developers.

Yes, I get that.

>> However, I also plan to setup an x2goagent-ng project (this is  upstream
>> information now) that also works with quilt. It would give a  much
>> better overview on what is X2Go code and what is the original NX  within
>> x2goagent. It would also ease working in nxagent updates that  come from
>> NoMachine. Hmmm... when thinking of this quilt is not  necessarily
>> needed, maybe an nxagent upstream branch that documents  the changes
>> between all nxagent versions is sufficient... (getting  off-topic
>> here...).
>
> Well, not really. TBH, I really think that this should be settled before
> doing any further work on the packaging.

I get your concerns here. You are actually pretty right on this. Will  
talk to Alex about this.

>> -> as NoMachine is active again on NX we should consider them as upstream?
>
> See above.
>
> Besides, you can only say that for sure when you start having contact
> with them. I'm glad that you volunteer to make this contact.

Ok, I'll try to get hold of them.

>> I will try to remove that folder before building and see what
>> compilation errors fail. If nothing fails it certainly means that we  do
>> not use those files. Will we then have to name them in the  copyright
>> file?
>
> Well, if we considered x2go as upstream, then we have only to 'declare'
> files that are distributed. Considering NX as 'upstream' makes things
> unnecessarily complicated.

I do see this as a problem while NoMachine is actively releasing code changes.
To become NX upstream the X2Go project people have to really fork NX  
libs and give everything a new name. This is not worth the hassle, I  
think.

The nxagent change of last release is quite big BTW:
http://anonscm.debian.org/gitweb/?p=collab-maint/x2go/nx-libs.git;a=commitdiff;h=c29053f82cbea5f2704d99c4d5e8afe0329e5cbe

>> Those are the *-dbg packages. The stripping of debug information did
>> not work with the nx-libs source tree. No idea why... Do we want *-dbg
>> packages? If yes, then may I ask you to take a look at that?
>
> Yes we want them, but only if they work. If they don't, then the
> commented out entries from debian/control is just cruft that is better
> removed.

I removed the cruft for now and hope that you find time to re-add the  
*-dbg packages. Thanks!

>> If it does not hurt there, I would like to leave it there, as it  allows
>> me to create a patched tarball for people who want to build  nx-libs.git
>> for other distros (LinuxFromScratch, Gentoo).
>
> Compared to editing a source file, editing a patch file is just a pain
> in the ass. Just avoid such nonsense and place the files directly in the
> packaging subdirectory (i.e., below debian)

dquilt push <patchname>
dquilt edit <filename>
dquilt pop -a
dch
debcommit -a

whereas dquilt is:

alias dquilt="quilt --quiltrc=${HOME}/.quiltrc-dpkg"

and ${HOME}/.quiltrc-dpkg is

"""
d=. ; while [ ! -d $d/debian -a `readlink -e $d` != / ]; do d=$d/..; done
if [ -d $d/debian ] && [ -z $QUILT_PATCHES ]; then
     # if in Debian packaging tree with unset $QUILT_PATCHES
     QUILT_PATCHES="debian/patches"
     QUILT_PATCH_OPTS="--reject-format=unified"
     QUILT_DIFF_ARGS="-p ab --no-timestamps --no-index --color=auto"
     QUILT_REFRESH_ARGS="-p ab --no-timestamps --no-index"
      
QUILT_COLORS="diff_hdr=1;32:diff_add=1;34:diff_rem=1;31:diff_hunk=1;33:diff_ctx=35:diff_cctx=33"
     if ! [ -d $d/debian/patches ]; then mkdir $d/debian/patches; fi
fi
"""

Cheers,
Mike


-- 

DAS-NETZWERKTEAM
mike gabriel, dorfstr. 27, 24245 barmissen
fon: +49 (4302) 281418, fax: +49 (4302) 281419

GnuPG Key ID 0xB588399B
mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: Digitale PGP-Unterschrift
URL: <http://lists.alioth.debian.org/pipermail/pkg-x2go-devel/attachments/20111231/1e05be8d/attachment.pgp>