[Pkg-xen-devel] Bug#661687: Bug#661687: xen-utils-common: TOOLSTACK setting not honored

[Bastian Blank]

On Wed, Feb 29, 2012 at 04:21:52PM +0530, Ritesh Raj Sarraf wrote:
> -TOOLSTACK=$(/usr/lib/xen-common/bin/xen-toolstack 2>/dev/null)
> -if [ $? -ne 0 ]; then
> -	log_warning_msg "No usable Xen toolstack selected"
> -	exit 0
> +
> +if [ -z $TOOLSTACK ]; then
> +	TOOLSTACK=$(/usr/lib/xen-common/bin/xen-toolstack 2>/dev/null)
> +	if [ $? -ne 0 ]; then
> +		log_warning_msg "No usable Xen toolstack selected"
> +		exit 0
> +	fi

This is, or at least should be, a null change.

The error handling is a bit off, it should not care about the value.

Bastian

-- 
Without freedom of choice there is no creativity.
		-- Kirk, "The return of the Archons", stardate 3157.4