[Pkg-xen-devel] Bug#703562: xen-utils-common: Unable to attach block device with special characters (spaces, etc.) in file or path name

[Mike Edwards]

Package: xen-utils-common
Version: 4.0.0-1
Severity: minor
Tags: patch

/etc/xen/scripts/block doesn't properly enclose $file in quotes for two out
of three stat calls, which causes the script to fail on files which contain
special characters (i.e. spaces) in their filename or pathname.

See attached for patch.


-- System Information:
Debian Release: 6.0.7
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-xen-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages xen-utils-common depends on:
ii  gawk                    1:3.1.7.dfsg-5   GNU awk, a pattern scanning and pr
ii  lsb-base                3.2-23.2squeeze1 Linux Standard Base 3.2 init scrip
ii  udev                    164-3            /dev/ and hotplug management daemo
ii  xenstore-utils          4.0.1-5.8        Xenstore utilities for Xen

xen-utils-common recommends no packages.

xen-utils-common suggests no packages.

-- Configuration Files:
/etc/xen/scripts/block changed [not included]
/etc/xen/xend-config.sxp changed [not included]

-- no debconf information
-------------- next part --------------
--- /etc/xen/scripts/block.orig	2010-06-21 09:46:02.000000000 -0400
+++ /etc/xen/scripts/block	2013-03-20 13:03:29.846945047 -0400
@@ -272,8 +272,8 @@
 
         if [ "x$mode" != 'x!' ]
         then
-          inode=$(stat -c '%i' $file)
-          dev=$(stat -c '%D' $file)
+          inode=$(stat -c '%i' "$file")
+          dev=$(stat -c '%D' "$file")
           if [ -z "$inode" ] || [ -z "$dev" ]
           then
             fatal "Unable to lookup $file: dev: $dev inode: $inode"