Bug#314922: [Pkg-xfce-devel] Bug#314922: xfdesktop4: update-menus overwrites $HOME/.config/xfce4/desktop/menu.xml

[Simon Huggins]

tags 314922 wontfix
thanks

See end for reasons.

On Mon, Jun 20, 2005 at 05:52:56PM +0200, Vincent Pelletier wrote:
> Some ideas for the "postrun" command :

Thanks for your analysis.

> 0) postrun="cp /etc/xdg/xfce4/desktop/system.menu.xml " prefix()
> "/menu.xml" (current package version)

> Problem : if user tweaks his menu.xml file, his changes are lost without
> asking when he runs update-menus.

Right, but if you have to explicitly run this so I don't think this is a
bug.  Anyone running a command called update-menus and expecting nothing
to happen is a bit broken in my opinion :)

I suppose we could rename the old menu if it exists perhaps.

> 1) postrun="test -e " prefix() "/menu.xml || cp
> /etc/xdg/xfce4/desktop/system.menu.xml " prefix() "/menu.xml"

> Problem : when root executes update-menus, the
> /etc/xdg/xfce4/desktop/menu.xml never gets overwritten since it exists
> in the xfdesktop package.

Yes and it has to exist there so that people without menu installed
still have a functional menu.

> 2) postrun="test -e " prefix() "/keep.menu.xml || cp ...

> Problem : adds a file in the config directory that isn't known from
> upstream.

And is ugly and upstream will start getting bug reports/queries about
it.  I don't really like this.

> 3) postrun="test -w " prefix() "/menu.xml || cp ...

> Problem : may be unclear why the file isn't overwritten. Makes the file
> overcomplicated to edit.

Will mean that running it as root never works too as the menudefs.hook
will be generated but the menu.xml won't be overwritten.

> No other ideas for now.
> The one that -to me- best solves the problem is the 2, but it has a
> bad drawback.

Yeah I'm not convinced by it.  I think I'll tag this wontfix for now.

Simon.

-- 
Just another wannabie | 'Une pause s'impose' -- Gianny |  Just another fool
----------------------+                                +-------------------
This message was brought to you by the letter G and the number  6.
htag.pl 0.0.22 -- http://www.earth.li/projectpurple/progs/htag.html