[Pkg-xfce-devel] Bug#491480: Bug#491480: I think i fixed the bug

[Yves-Alexis Perez]

On mer, 2008-08-06 at 03:20 +0200, Daniel Gibson wrote:
> Good new everyone,
> 
> I found the bug (or at least the one that made the plugin crash for
> _me_).
> It's in panel-plugin/acpi.c in refresh_acpi().
> The (broken) code is at line 475:
> 
> case STATE:
>         file = g_strdup_printf ("%s/%s/state", ACPI_DIR_FAN,
> cf->devicename);
>         cf->raw_value = strcmp(get_acpi_value(file), "on")==0 ? 1.0 :
> 0.0;
> 
> The problem is, that get_acpi_value() (in contrast to
> get_acpi_zone_value() for example) expects a _full_ path to the file.

Ok I guess that's why I don't have crashes on this box: I don't have
anything in /proc/acpi/fan so the STATE part is never entered.

I'll try to build the plugin with the patch and report back, stay tuned.

btw strac'ing the plugin I saw that it tries to
open /proc/acpi/battery/battery/BAT0 which doesn't exist here
(it's /proc/acpi/battery/BAT0). What do you have (if you have a
battery)?

Cheers,
-- 
Yves-Alexis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20080806/19e64c7e/attachment.pgp