[Pkg-xfce-devel] Bug#575424: libexo-0.3-0: exo-compose-mail-0.3 should pass mailto URLs to mutt unbroken

[Scott Barker]

Package: libexo-0.3-0
Version: 0.3.106-1
Severity: normal


mutt can handle mailto URLs just fine. Instead of breaking the mailto URL
apart and passing in separate parameters, exo-compose-mail-0.3 should use
logic for mutt similar to the logic for balsa. The attached patch fixes
this.

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_CA.utf8, LC_CTYPE=en_CA.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages libexo-0.3-0 depends on:
ii  libatk1.0-0             1.28.0-1         The ATK accessibility toolkit
ii  libc6                   2.10.2-6         Embedded GNU C Library: Shared lib
ii  libcairo2               1.8.10-3         The Cairo 2D vector graphics libra
ii  libdbus-1-3             1.2.20-2         simple interprocess messaging syst
ii  libexo-common           0.3.106-1        libexo common files
ii  libfontconfig1          2.8.0-2          generic font configuration library
ii  libfreetype6            2.3.11-1         FreeType 2 font engine, shared lib
ii  libglib2.0-0            2.22.4-1         The GLib library of C routines
ii  libgtk2.0-0             2.18.9-2         The GTK+ graphical user interface 
ii  libhal-storage1         0.5.14-2         Hardware Abstraction Layer - share
ii  libhal1                 0.5.14-2         Hardware Abstraction Layer - share
ii  libnotify1 [libnotify1- 0.4.5-1          sends desktop notifications to a n
ii  libpango1.0-0           1.26.2-2         Layout and rendering of internatio
ii  liburi-perl             1.52-1           module to manipulate and access UR
ii  libxfce4util4           4.6.1-2          Utility functions library for Xfce
ii  zlib1g                  1:1.2.3.4.dfsg-3 compression library - runtime

libexo-0.3-0 recommends no packages.

libexo-0.3-0 suggests no packages.

-- no debconf information
-------------- next part --------------
--- exo-compose-mail-0.3.old	2010-03-25 11:59:45.000000000 -0600
+++ exo-compose-mail-0.3	2010-03-25 11:59:47.000000000 -0600
@@ -178,21 +178,21 @@
 }
 elsif ($style eq 'mutt') {
 	# generate the parameters for mutt
+	my $mailto = 'mailto:' . ((@to > 0) ? uri_escape($to[0]) : "") . '?';
+	for (my $n = 1; $n < @to; $n++) {
+		$mailto .= 'cc=' . uri_escape($to[$n]) . '&';
+	}
 	for my $cc (@cc) {
-		push (@argv, '-c', $cc);
+		$mailto .= 'cc=' . uri_escape($cc) . '&';
 	}
+	$subject and $mailto .= 'subject=' . uri_escape($subject) . '&';
+	$body and $mailto .= 'body=' . uri_escape($body);
+
+	# and add the parameters to the argv
+	push (@argv, $mailto);
 	for my $uri (@attachments) {
 		push (@argv, '-a', $uri->path ());
 	}
-	$subject and push (@argv, '-s', $subject);
-	for my $to (@to) {
-		push (@argv, $to);
-	}
-
-	# mutt needs an address, if we don't have
-	# any, just append an empty string and mutt
-	# will prompt for the To: address
-	(not @to) and push (@argv, '');
 }
 else {
 	print STDERR "$0: Unsupported style '$style'.\n";