[Pkg-xfce-devel] Bug#601968: notification-daemon-xfce sends invalid single-argument NotificationClosed signal

[Jo Shields]

Package: notification-daemon-xfce
Version: 0.3.7-2
Severity: normal
Tags: patch

As discussed in Debian bug #527553 and XFCE bug #5339, the FreeDesktop
spec for notifications requires a "reason" argument for NotificationClosed
signals. xfce4-notifyd has been patched to provide this, but 
notification-daemon-xfce has not. Attached is a simplistic patch to add
this required argument (the reason given is always "The notification was 
dismissed by the user", even if this is not true - it was deemed the simplest
way to add a patch).

The attached patch has been tested with some apps, e.g. Banshee, and doesn't
exhibit the problems cited in bug #527553.

-- System Information:
Debian Release: squeeze/sid
  APT prefers maverick-updates
  APT policy: (500, 'maverick-updates'), (500, 'maverick-security'), (500, 'maverick-backports'), (500, 'maverick')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.35-22-generic (SMP w/8 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages notification-daemon-xfce depends on:
ii  libatk1.0-0      1.32.0-0ubuntu1         The ATK accessibility toolkit
ii  libc6            2.12.1-0ubuntu8         Embedded GNU C Library: Shared lib
ii  libcairo2        1.10.0-1ubuntu2         The Cairo 2D vector graphics libra
ii  libdbus-1-3      1.4.0-0ubuntu1          simple interprocess messaging syst
ii  libdbus-glib-1-2 0.88-2                  simple interprocess messaging syst
ii  libfontconfig1   2.8.0-2ubuntu1          generic font configuration library
ii  libfreetype6     2.4.2-2                 FreeType 2 font engine, shared lib
ii  libglib2.0-0     2.26.0-0ubuntu1         The GLib library of C routines
ii  libgtk2.0-0      2.22.0-0ubuntu1         The GTK+ graphical user interface 
ii  libnotify1 [libn 0.5.0-2ubuntu1          sends desktop notifications to a n
ii  libpango1.0-0    1.28.1-1ubuntu3         Layout and rendering of internatio
ii  libsexy2         0.1.11-2build2          collection of additional GTK+ widg
ii  libx11-6         2:1.3.3-3ubuntu1        X11 client-side library
ii  libxfce4util4    4.6.2-1ubuntu1          Utility functions library for Xfce
ii  libxfcegui4-4    4.6.4-1                 Basic GUI C functions for Xfce4
ii  libxml2          2.7.7.dfsg-4            GNOME XML library
ii  zlib1g           1:1.2.3.4.dfsg-3ubuntu1 compression library - runtime

notification-daemon-xfce recommends no packages.

notification-daemon-xfce suggests no packages.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: notification-daemon-xfce_send_NotificationClosed_arguments.diff
Type: text/x-diff
Size: 622 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20101031/5383e7b7/attachment.diff>