[Pkg-xfce-devel] Bug#684408: lightdm-gtk-greeter: The debian source is unable to perform a compilation more than once

[Manuel Sabban]

Package: lightdm-gtk-greeter
Version: 1.1.6-2
Severity: normal
Tags: patch

Hi, 

We have here the need for a locally modified version of lightdm-gtk-greeter. The debianized source provided by apt-get source lightdm-gtk-greeter is unable to perform a compilation more than once. Sure, the package is can be built but I think it's not effective enough.

In fact, the upstream rules of cleaning is a bit aggressive in regard of the debian way of building the package. Some needed files for the compilation are deleted during the second build. So here's a patch which do the trick of keeping these files in the tree. I don't know if it the right debian way to fix this up.

patch follow

--- lightdm-gtk-greeter-1.1.6.orig/Makefile.in
+++ lightdm-gtk-greeter-1.1.6/Makefile.in
@@ -290,19 +290,11 @@ EXTRA_DIST = \
 	lightdm-gtk-greeter.doap
 
 DISTCLEANFILES = \
-	Makefile.in \
-	aclocal.m4 \
-	configure \
-	config.h.in \
 	config.h \
-	depcomp \
 	gtk-doc.make \
-	install-sh \
-	missing \
 	mkinstalldirs \
 	omf.make \
 	xmldocs.make \
-	po/Makefile.in.in
 
 all: config.h
 	$(MAKE) $(AM_MAKEFLAGS) all-recursive
--- lightdm-gtk-greeter-1.1.6.orig/Makefile.am
+++ lightdm-gtk-greeter-1.1.6/Makefile.am
@@ -5,16 +5,9 @@ EXTRA_DIST = \
 	lightdm-gtk-greeter.doap
 
 DISTCLEANFILES = \
-	Makefile.in \
-	aclocal.m4 \
-	configure \
-	config.h.in \
 	config.h \
-	depcomp \
 	gtk-doc.make \
-	install-sh \
-	missing \
 	mkinstalldirs \
 	omf.make \
 	xmldocs.make \
-	po/Makefile.in.in
+
--- lightdm-gtk-greeter-1.1.6.orig/data/Makefile.in
+++ lightdm-gtk-greeter-1.1.6/data/Makefile.in
@@ -267,8 +267,7 @@ icondir = $(greeterdatadir)/hicolor/scal
 dist_icon_DATA = accessibility.svg system-shutdown.svg
 configdir = $(sysconfdir)/lightdm
 dist_config_DATA = lightdm-gtk-greeter.conf
-DISTCLEANFILES = \
-	Makefile.in
+DISTCLEANFILES = ""
 
 all: all-am
 
--- lightdm-gtk-greeter-1.1.6.orig/src/Makefile.in
+++ lightdm-gtk-greeter-1.1.6/src/Makefile.in
@@ -276,8 +276,7 @@ lightdm_gtk_greeter_CFLAGS = \
 lightdm_gtk_greeter_LDADD = \
 	$(GREETER_LIBS)
 
-DISTCLEANFILES = \
-	Makefile.in
+DISTCLEANFILES = ""
 
 all: all-am
 
--- lightdm-gtk-greeter-1.1.6.orig/po/Makefile.in.in
+++ lightdm-gtk-greeter-1.1.6/po/Makefile.in.in
@@ -166,7 +166,6 @@ distclean: clean
 maintainer-clean: distclean
 	@echo "This command is intended for maintainers to use;"
 	@echo "it deletes files that may require special tools to rebuild."
-	rm -f Makefile.in.in
 
 distdir = ../$(PACKAGE)-$(VERSION)/$(subdir)
 dist distdir: $(DISTFILES)


-- System Information:
Debian Release: wheezy/sid
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to fr_FR.UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lightdm-gtk-greeter depends on:
ii  libc6                   2.13-33
ii  libcairo2               1.12.2-2
ii  libgdk-pixbuf2.0-0      2.26.1-1
ii  libglib2.0-0            2.32.3-1
ii  libgtk-3-0              3.4.2-2
ii  liblightdm-gobject-1-0  1.2.2-3
ii  libx11-6                2:1.5.0-1

Versions of packages lightdm-gtk-greeter recommends:
ii  desktop-base           7.0.0
ii  gnome-icon-theme       3.4.0-2
ii  gnome-themes-standard  3.4.2-1
ii  policykit-1            0.105-1

lightdm-gtk-greeter suggests no packages.

-- no debconf information