[Pkg-xfce-devel] Bug#690899: lightdm: Inconsistent behavior when storing default session and language

[John Paul Adrian Glaubitz]

Package: lightdm
Version: 1.4.0-1
Severity: normal
Tags: patch

Hello,

as lightdm allows to select the default language and session during
login, it stores these settings both in the old-fashioned .dmrc file
in the home directory as well in /var/lib/AccountsService/users/$USER.

However, while testing lightdm as a replacement for gdm 2.20, I figured
out that lightdm writes the default language and session selection
inconsistently to the aforementioned places. While both language
and session are always stored in /var/lib/AccountsService/users/$USER
through AccountsService, the language selection is never stored in the
.dmrc file, the settings between these two locations are therefore
inconsistent.

I'm attaching a small patch which fixes this behaviour and which also
adds an additional check for a valid pointer in user_set_xsession
as it is done in user_set_language.

I would also like to point out, that it would actually make more sense
to be able to configure whether .dmrc or AccountsService are used to
store the default session and language [1]. In this case, this patch
could be discarded and the bug report closed.

Cheers,

Adrian

> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=690898

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing'), (100, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.5-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lightdm depends on:
ii  adduser                                3.113+nmu3
ii  consolekit                             0.4.5-3.1
ii  dbus                                   1.6.8-1
ii  debconf [debconf-2.0]                  1.5.46
ii  libc6                                  2.13-35
ii  libglib2.0-0                           2.32.3-1
ii  libpam0g                               1.1.3-7.1
ii  libxcb1                                1.8.1-1
ii  libxdmcp6                              1:1.1.1-1
ii  lightdm-gtk-greeter [lightdm-greeter]  1.1.6-2

Versions of packages lightdm recommends:
ii  xserver-xorg  1:7.7+1

Versions of packages lightdm suggests:
ii  accountsservice  0.6.21-6
ii  upower           0.9.17-1

-- debconf information excluded
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lightdm-fix-dmrc-handling.patch
Type: text/x-diff
Size: 2532 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-xfce-devel/attachments/20121018/4bde000b/attachment.patch>