[Pkg-xmpp-devel] Sponsorship of the Jappix package

[Marcelo Jorge Vieira]

Hi Philippe,

This is my initial review:

debian/control:
===============

1) Add Vcs-Browser and Vcs-git field [0].

2) ejabberd should be "suggests" instead of a "recommends",
   because packages from "recommends" field are installed by default,
   and/or ejabberd can be installed in another machine.

[0] http://is.gd/iEMu6r


debian/copyright:
=================

1) You must make mention in debian/copyright of all copyright holders
   and licenses. You forgot:

   + css/stats-svg.css
   + js/base64.js
   + js/browser-detect.js
   + js/constants.js
   + js/jquery.datepicker.js
   + js/jquery.form.js
   + jquery.js
   + jquery.placeholder.js ? (I can include this lib in jquery-goodies)
   + jquery.timers.js (I can include this lib in jquery-goodies)
   + jsjac.js
   + jxhr.js
   + php/bosh.php
   + php/drawsvgchart.php
   + php/functions-get.php
   + php/functions-manager.php
   + php/functions.php
   + php/gettext.php
   + php/mobile-detect.php  
 
2) Please, remove php/jsmin.php from upstream tarball because
   it is a non-free software [1]. Also, you need change the
   name of upstream tarball, read the section 2 here [2].

   You must do that for each upstream release. I suggest you
   to add the get-orig-source target in debian/rules, there is
   an example here [3].

[1] http://lists.debian.org/debian-legal/2009/09/msg00034.html
[2] http://is.gd/KhGrQu
[3] http://is.gd/tLhXJq


3) The php/gettext.php is a debian package (php-gettext).

4) The jquery.form.js is a debian package (libjs-jquery-form).


If you have any questions, please do not hesitate to contact me.


Cheers,

-- 
Marcelo Jorge Vieira
xmpp:metal at jabber-br.org
http://metaldot.alucinados.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-xmpp-devel/attachments/20110422/02d32d36/attachment.pgp>