[Pkg-zope-developers] Summary of the NMU of zope, and ask for review about a patch

Pierre Machard pmachard@debian.org
Wed, 25 Aug 2004 08:53:51 +0200


--ALfTUftag+2gvp1h
Content-Type: multipart/mixed; boundary="oLBj+sq0vYjzfsbl"
Content-Disposition: inline


--oLBj+sq0vYjzfsbl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

As you probably know, I made severals NMU of zope in order to fix the
zopectl bug. To be honnest I had firstly no intention to get involved in
zope-packaging in Debian, but...

I will upload a new package tonight, or tomorrow in order to compile in
any architecture. We had discovered a bug in recent tetex-* packages. I
will comment the line in debian/rules where we build the zope-policy.

Instead I will build it localy, and put zope-policy.{txt,ps,pdf,html}
into the package.

Before doing that, I need someone to check the postinst, and told me if
I can rely on the patch proposed in attachement ? I know that I do not
let you a lot of time to achieve that, but do not forget that sarge is
about to be released, and zope must be fixed.

Ah, I also wonder if zope2.7 need to be fixed or if it is not usefull.
IIRC, there is a conflicts in the debian/control of zopectl package.

Thanks in advance for your comments,
P.S. Thaddeus perhaps you could aslo subscribe to this mailing list.
--=20
                                Pierre Machard
<pmachard@debian.org>                                 http://debian.org
GPG: 1024D/23706F87 : B906 A53F 84E0 49B6 6CF7 82C2 B3A0 2D66 2370 6F87


--oLBj+sq0vYjzfsbl
Content-Type: message/rfc822
Content-Disposition: inline

Return-path: <owner@packages.qa.debian.org>
Envelope-to: pierre@machard.com
Delivery-date: Tue, 24 Aug 2004 21:11:25 +0200
Received: from master.debian.org ([146.82.138.7])
	by caribou.migus.eu.org with esmtp (Exim 4.34)
	id 1BzghZ-0000Kq-8G
	for pierre@machard.com; Tue, 24 Aug 2004 21:11:25 +0200
Received: from hertzog by master.debian.org with local (Exim 3.35 1 (Debian))
	id 1BzgeW-0002Fa-00; Tue, 24 Aug 2004 14:08:16 -0500
Received: from spohr.debian.org [128.193.0.4] by master.debian.org with
    esmtp (Exim 3.35 1 (Debian)) id 1BzgeV-0002Ee-00; Tue, 24 Aug 2004
    14:08:15 -0500
Received: from debbugs by spohr.debian.org with local (Exim 3.35 1
    (Debian)) id 1BzgZV-00051e-00; Tue, 24 Aug 2004 12:03:05 -0700
X-Loop: owner@bugs.debian.org
Subject: Bug#267528: [pmachard@debian.org: Fixed in NMU of zopectl 0.3.4.2]
Reply-To: frank@kuesterei.ch (=?iso-8859-1?q?Frank_K=FCster?=),
    267528@bugs.debian.org
Resent-From: frank@kuesterei.ch (=?iso-8859-1?q?Frank_K=FCster?=)
Original-Sender: frank.kuester@unibas.ch
Resent-To: debian-bugs-dist@lists.debian.org
Resent-CC: Luca - De Whiskey's - De Vitis <luca@debian.org>
Resent-Date: Tue, 24 Aug 2004 19:03:04 UTC
Resent-Message-Id: <handler.267528.B267528.109337358810811@bugs.debian.org>
X-Debian-PR-Message: report 267528
X-Debian-PR-Package: zope
X-Debian-PR-Keywords: fixed
Received: via spool by 267528-submit@bugs.debian.org
    id=B267528.109337358810811 (code B ref 267528); Tue, 24 Aug 2004 19:03:04
    UTC
Received: (at 267528) by bugs.debian.org; 24 Aug 2004 18:53:08 +0000
Received: from moutng.kundenserver.de [212.227.126.177] by
    spohr.debian.org with esmtp (Exim 3.35 1 (Debian)) id 1BzgPs-0002nC-00;
    Tue, 24 Aug 2004 11:53:08 -0700
Received: from [212.227.126.160] (helo=mrelayng.kundenserver.de) by
    moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BzgPo-0007wJ-00;
    Tue, 24 Aug 2004 20:53:04 +0200
Received: from [82.194.101.52] (helo=alhambra.bioz.unibas.ch) by
    mrelayng.kundenserver.de with asmtp (Exim 3.35 #1) id 1BzgPn-0004o9-00;
    Tue, 24 Aug 2004 20:53:03 +0200
Received: from localhost ([127.0.0.1] helo=alhambra.bioz.unibas.ch) by
    alhambra.bioz.unibas.ch with esmtp (Exim 3.35 #1 (Debian)) id
    1BzgIA-0000O3-00; Tue, 24 Aug 2004 20:45:10 +0200
To: "Thaddeus H. Black" <t@b-tk.org>
Cc: Pierre Machard <pmachard@debian.org>, Laszlo 'GCS' Boszormenyi
    <gcs@lsc.hu>, submitter-267528@bugs.debian.org,  267528@bugs.debian.org,
    251038@bugs.debian.org
Sender: frank.kuester@unibas.ch
X-Attribution: fant
X-Ehrenamt: http://www.langau.de
From: frank@kuesterei.ch (=?iso-8859-1?q?Frank_K=FCster?=)
In-Reply-To: <20040824173223.GA353@b-tk.org> (Thaddeus H. Black's message
    of
    "Tue, 24 Aug 2004 17:32:23 +0000")
References: <20040822111809.GA20987@bretagne.cn>
    <20040823123708.GB841@b-tk.org> <20040823172431.GB10804@bretagne.cn>
    <20040823211950.GA415@b-tk.org> <20040824173223.GA353@b-tk.org>
Date: Tue, 24 Aug 2004 20:45:05 +0200
Message-Id: <874qmsqssu.fsf@alhambra.bioz.unibas.ch>
User-Agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Provags-Id: kundenserver.de abuse@kundenserver.de auth:3fc7da83a58b7314ee3070631872032d
Delivered-To: 267528@bugs.debian.org
X-Crossassassin-Score: 2
Resent-Sender: Debian BTS <debbugs@bugs.debian.org>
Delivered-To: zope@packages.qa.debian.org
Precedence: list
X-Loop: zope@packages.qa.debian.org
X-PTS-Package: zope
X-PTS-Keyword: bts
X-Unsubscribe: echo 'unsubscribe zope' | mail pts@qa.debian.org
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on caribou.migus.eu.org
X-Spam-Level: 
X-Spam-Status: No, hits=-4.9 required=2.5 tests=AWL,BAYES_00 autolearn=no 
	version=2.63

"Thaddeus H. Black" <t@b-tk.org> schrieb:

> This mail is to Pierre Machard, but let
> submitter Georg Hoermann also please observe.
>
>>        {
>>             ACCESS_DEFAULT=3Ddefault
>>             if [ ! -e $access ] ; then
>>                 mkdir -p $access
>>                 if [ ! -e $access/$ACCESS_DEFAULT ] ; then
>>                         touch $access/$ACCESS_DEFAULT
>>                         echo "Please enter a password for Zope's initial=
/emergency user."
>>                         zopectl --access "$ACCESS_DEFAULT"
>>                 fi
>>             fi
>>         }
>
> I think that I now see the reason for
> the "if [ ! -e $access ]" you have added to zope
> postinst.  Do not be angry if I say that the
> addition is probably not quite what we want.
> Reason: it prevents the creation of the
> file $access/$ACCESS_DEFAULT when the directory
> $access/ already exists.  This is incorrect
> behavior.  I would recommend removing
> the "if [ ! -e $access ]" wrapper from around
> the block.

I'd rather say you have to separate it:

if [ ! -e $access ] ; then
    mkdir -p $access
fi
if [ ! -e $access/$ACCESS_DEFAULT ] ; then
    touch $access/$ACCESS_DEFAULT
    echo "Please enter a password for Zope's initial/emergency user."
    zopectl --access "$ACCESS_DEFAULT"
fi

> I think that zope actually needs the directory.
> If there were an old file with the new
> directory's name, the old file would need to
> move out of the way.  Policywise, what would be
> the right way to handle this?

Was this file installed from the deb, or always created from a maintainer
script?=20

Regards, Frank
--=20
Frank K=FCster, Biozentrum der Univ. Basel
Abt. Biophysikalische Chemie





--oLBj+sq0vYjzfsbl--

--ALfTUftag+2gvp1h
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBLDd/s6AtZiNwb4cRAivXAJ9CFKkIjSUHKMAEJhy7vDU3yKPrXACfd3WI
5lsNjn7I3M2p5jYyLt2HP8Q=
=EAwR
-----END PGP SIGNATURE-----

--ALfTUftag+2gvp1h--