QA before uploading zope packages

[Gediminas Paulauskas]

Good morning,

2011/11/7 Arnaud Fontaine <arnau at debian.org>:
> Hi,
>
> Gediminas Paulauskas <menesis at pov.lt> writes:
>
>> You have insisted on me adding debian/clean to all packages before you
>> will upload them.
>>
>> It did look suspicious to  delete .egg-info directory from source, you
>> get  a   few  lines  of   warnings  'Ignoring  deletion   of...'  from
>> dpkg-buildpackage -S.
>>
>> And as I feared, there are problems with this approach.
>
> Well, you  could have tested  them after making the  changes, apparently
> you didn't  check them,  and in  your email you're  only saying  it's my
> fault, come  on... So  easy to  complain about  the sponsor  whereas the
> sponsoree is usually the person who knows the packages the most.
>
> On the other hands, it's also my fault because if I could have tested it
> myself, I would  have probably figured it out, meaning  that I obviously
> don't know enough  about these packages to upload them,  so I should not
> do it again, this was a mistake... Sorry about that.

The point is not to complain. We did something, but it turned out badly.

I have started syncing packages from Debian to Ubuntu. I discovered a
problem, investigated it, found the issue was in the last changes
before upload. I described the issue, when and why it happened, to
developers mailing list.

Now there is work to do. I am disappointed as much as you are.

Since you will be doing the uploads, and the changes are minimal, you
will have to do this yourself:

  cd $package
  svn rm debian/clean
  dch -i -m 'debian/clean: remove to ensure all files are installed'
  svn diff
  svn-buildpackage -S
  debcommit -r -R
  # upload

The fails-to-build-twice bug remains unsolved, but all the other good
changes will become available.

>>> Also,  for    debian/control,  please  don't  forget    Homepage  and
>>> Vcs-Browser fields  and for  debian/changelog  "Team  upload" like  I
>>>  did to  avoid lintian warning about NMUs.
>>>
>>> I know  I'm far too fuzzy  about  details, hope that does  not bother
>>> you too much ;).
>>
>> It does bother me.
>
> Stop arguing and complaining, it's getting really tiresome. For example,
> you  spent  a  lot  of  time  to  complain  about  adding  Homepage  and
> Vcs-Browser fields, whereas you could  have just added them instead. I'm
> getting  so tired  of your  attitude, because  most sponsorees  just say
> thanks for taking care of details, but you're the only one I know who is
> arguing so loudly.

It is a working discussion between developers, maintainers, and
sponsors. Each have their own work methods, preferences, and
responsibility. This episode ended in flames, but we will have to fix
that, do other things, new upstream releases, and so on, in the
future. Each of us has to learn.

I need to get work done, but the process was stuck on Debian side. You
came to help, and I am very happy that you did.

I contributed everything done in Ubuntu to Debian, and asked for that
to be uploaded so that the same packages are in both distributions.
Whatever other changes are made in Debian afterwards, will be
automatically synced to Ubuntu. So there is less work for me in
Ubuntu.

Debian packages have not been uploaded for a long time, and pending
changes were accumulating, including the dh_python2 transition. It was
feature freeze, so no more changes were expected until 11.10 release,
so a good time to catch up upstream, before automatic debian sync of
the next cycle starts. Ideally, I would have liked these uploads to be
exactly the same as in Ubuntu 11.10, to have a common starting point.

Then you asked to do a few more small changes, that was expected from
a sponsor. Some of them, e.g. Format-Specification and ZPL-2.1 were
producing lintian warnings, so they had to be fixed.

But others were not important, and that's what I said, asking to
simply upload what's available already. Do what you want later.

Vcs-Browser is not something that is worth delaying an upload or even
a changelog entry. Also, it is useless in Ubuntu. Another change,
source/format, is risky. That's why I wanted to avoid doing this and
similar changes at the time.

> Yes, adding debian/clean was perhaps a mistake, but if we didn't do such
> changes,  we  would have  got  many  serious  bugs when  rebuilding  the
> archive (and again, see the bug  report we got for another package which
> was reproducible with *ALL* or almost all the packages you prepared).

Then in the middle of me doing the first round of tasks, you come to
me demanding that debian/clean is absolutely needed to be included. I
understand that the problem is very obscure, cannot reproduce it,
there is no good fix, and the proposed workaround is suspicious. But I
do not have evidence, so I back down, we split the work and implement
this.

Because I have rebuilt and tested these packages just a few hours
before, and I got tired of demands, I do what was asked from me just
to get this done, and commit without testing. Then no one notices
packages are broken for two weeks.

But this could be avoided. Just by placing less demands on yourself
and others, and not changing things that work because they could be
changed.

>> Packages may  not be perfect,  but if they contain  significant fixes,
>> they are  worth an upload. I  have asked several times  to just upload
>> packages that were already in Ubuntu.
>
> When you  will be able to  upload the packages yourself,  you can upload
> anything you want, but now that's not the case.

That's what I do, being the maintainer of these same packages in
Ubuntu. We are in opposite positions there. I have to review and merge
your changes. I don't like them, and I said so before you started
making them. But you squeezed in everything anyway, and now you have
broken packages in Debian. Now I have to wait yet again for Debian to
catch up, or merge and revert the offending change, and then do a sync
later... Much work for little benefit. Ubuntu packages are fine as
they are.

> Anyhow, as I said above, 1/ I'm not a good sponsor for Zope package as I
> don't  know/use them  enough, 2/  I'm so  tired of  you complaining  and
> arguing for nothing, therefore, feel  free to find another sponsor (BTW,
> I did the uploads just to help because nobody else seemed to care enough
> to sponsor them...).

We are maintainers without upload rights. We have to know the
packages, and make them work. If they look reasonably OK, you upload
them. Thank you very much.

You wanted to make them even better. Very welcome. But you stepped on
some false positives and hidden traps, and we have pointed them out to
you. The result is that three weeks later, you have to do it all over
again.

-- 
Gediminas