QA before uploading zope packages
menesis at pov.lt
Tue Nov 8 12:48:06 UTC 2011
2011/11/8 Arnaud Fontaine <arnau at debian.org>:
> Gediminas Paulauskas <menesis at pov.lt> writes:
>> The fails-to-build-twice bug remains unsolved, but all the other good
>> changes will become available.
> Well, as I said before, this is a release goal, so I'm not going to
> upload them without fixing this issue (which would lead to serious bugs
> at the end).
There may be other bugs that are to be solved in the future.
But first there is a finished dh_python2 transition that has to be uploaded.
Then we can fix whatever else issues come. Upgrade to ZTK 1.1. Add
manpages. So on.
> Another quick workaround if nobody has time to investigate the issue
> would be to drop debian/clean and ignore the content of *.egg-info
> directory when generating the diff by using --extend-diff-ignore option
> of dpkg-source. This can be done by adding something like that in
> extend-diff-ignore = ".*\.egg-info/.*"
> Not the best solution but at least it gets things done (I have just
> tested and it works well, e.g. zcml files are included and double build
> works well) without uploading packages which will trigger serious bugs
> soonish. What do you think about that?
I do not see this as a workaround. Looks like an option intended
exactly for such purpose.
The regex does not need to be enclosed in ".*" "\.egg-info/" works and
I have tested this with zope.i18n and it solves both issues.
>> SOURCES.txt contains a list of files that have to be installed by
>> setup.py install. It is generated by setup.py sdist and uses svn
>> status to determine what files should be installed.
> Hrm, from an upstream point of view, isn't it supposed to be done
> through package_data setup() parameter in setup.py? Not sure though...
Maybe. Existing zope packages don't do that.
>> Debian packages have not been uploaded for a long time, and pending
>> changes were accumulating, including the dh_python2 transition. It was
>> feature freeze, so no more changes were expected until 11.10 release,
>> so a good time to catch up upstream, before automatic debian sync of
>> the next cycle starts. Ideally, I would have liked these uploads to be
>> exactly the same as in Ubuntu 11.10, to have a common starting point.
> Well, I get your point but the double build issue was caused by a recent
> upload of dpkg which was not already in Ubuntu as I told you on IRC.
I have now reproduced it by
Now running lintian...
W: zope.i18n source: format-3.0-but-debian-changes-patch
W: python-zope.i18n: wrong-section-according-to-package-name
python-zope.i18n => python
Finished running lintian.
Not a failure, because Ubuntu has dpkg 22.214.171.124, but a lintian warning,
and a generated patch.
The fix suggested at the top solves this.
> Exactly, that's why I fixed a lot of packages myself before uploading
> them. But, this kind of things has to be done at some point, better be
> sooner than later IMO. About source/format, yes it was too risky
> considering the issue we now have, sorry about that.
First I wanted debian to catch up to ubuntu. Then do those other things.
This is already an annoyance for me, because I have to review more
changes on both sides when merging from debian to ubuntu.
> double build is a release goal
> (perhaps it's not for Ubuntu, I don't know at all...).
double build is not an issue in Ubuntu build farm I think. Each build
happens in a clean environment.
A release goal for the previous Ubuntu was dh_python2 transition.
That's why I wanted them uploaded sooner rather than after some more changes.
> Could you please list the packages which have to be uploaded? Thanks.
The tool that we Build-Depend on in some packages, van.pydeb, is still
not uploaded. It should be uploaded FIRST.
Then, all the other packages that have been changed recently.
$ ls */debian/clean
Those that contain zcml files (txt too) are more important.
More information about the pkg-zope-developers