[Python-apps-team] ITP: phatch: a photo batch processor

[SPE Stani's Python Editor]

Hi Emilio,
Thanks for your feedback! I have applied all patches in bazaar:
$ bzr commit -m "Thankfully applying Emilio's patches for packaging"
modified images/phatch-logo.png
modified linux/phatch.desktop
modified phatch/actions/round.py
modified phatch/data/info.py
modified phatch/data/version.py
modified setup.py
Committed revision 166.

One thing I did differently. I moved the "import Image" in info.py
into a function which doesn't get called during setup.py  The
info.SETUP contains all important metadata for setup and can not be
ommitted (for sure not on Windows or Mac). But the result is the same:
Image does not get imported anymore during setup.py I didn't
understand the new line ending patches at the end of the files. As I
thought they are not important, I ignored them.

Let me know if you have further comments. As I said I prefer that
phatch doesn't have to be patched for debian packaging.

Stani

On Dec 6, 2007 2:54 PM, Emilio Pozuelo Monfort <pochu27 at gmail.com> wrote:
> Emilio Pozuelo Monfort wrote:
> > Stani, I've made a couple of fixes to Phatch, attached is a patch:
>
> And one more thing I've forgot, which I can make a patch:
> images/phatch-logo.png is executable, could you change it? Of course that's
> minor stuff and not very important, but anyway ;)
>
> Best,
> Emilio
>
>
> >
> > For the desktop file, the Version key is the freedesktop.org desktop
> > specification version to which the desktop file complies. It is 1.0 currently.
> > Also, the icon doesn't need to have a extension. The desktop file will
> > automatically take the best one if there is the same icon with different extensions.
> >
> > And the Application value for the Category key is deprecated, as is the Encoding
> > key, which is deprecated because it has to be utf-8 now.
> >
> > For round.py, I don't think we need the hashbang, as it is imported from the
> > phatch (correct me if I'm wrong) and not intended to be executed directly.
> >
> > And the setup.py, I've commented that because when it imports info, it imports
> > Image too, and I don't want to build-depend on python-imaging if we can avoid it.
> >
> > Do you really need to add all that info to the setup script? It's in Help>About
> > anyway. Isn't that enough? If possible, would be nice if you can fix it.
> >
> > Thanks!
> > Emilio
> >
>
>
>



-- 
http://pythonide.stani.be