[Python-apps-team] Bug#513183: Bug#513183: mercurial: pre-approving and sponsoring a possible NMU upload to t-p-u to fix an important bug (#513183)

[Eddy Petrișor]

>   Hi,
>=20
> Adeodato Sim=C3=B3 wrote:
>> * Eddy Petri=C8=99or [Fri, 30 Jan 2009 17:54:03 +0200]:
>>
>>> Hello release team,
>> Hello, Eddy (and Mercurial maintainers).
>>
>> Here are my thoughts on the issue:
>>
>>   - a patch for this should really get an ACK from the maintainers
>=20
> I quickly look at your (Eddy) patch and I read your description. It see=
ms
> an elegant way to solve the problem.
> Did you try to talk to upstream with this problem ? Did they acknowledg=
e

No I haven't talked to them. Indeed, the quick fix I provided is not the
right solution for upstream, but it looks like a good workaround for
lenny since we're closer and closer to the release (now that D-I rc2 was
announced).

> the problem ? Or even your patch ? (but I think they will prefer modify=

> hgk itself to call hg with the quiet option instead of adding yet a wra=
pper).

The proper fix is to actually modify the hgk code to actually enclose
each call to hg from hgk into a tcl/tk catch clause and test for the
result of $::errorCode and proceed if that is "NONE".

I can provide my modified hgk in this direction, still I am unsure this
would be really useful since this was my first attempt to change a
tcl/tk program and it would definitely be inappropriate for lenny since
there are many changes in that code to make it ignore warnings.


If fixing hgk proves to be too difficult, upstream could add a "nowarn"
configuration to hg and always call hg with that option on.

> I would prefer to have some input from upstream before modifying our ve=
rsion of
> mercurial. But unless upstream strongly oppose to your patch, I will ad=
d it
> (or a variant) in the Debian package.

OK, I can talk with upstream about this issue.

>   Many thank for your patch

You're welcome.

--=20
Regards,
EddyP
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
"Imagination is more important than knowledge" A.Einstein

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: OpenPGP digital signature
Url : http://lists.alioth.debian.org/pipermail/python-apps-team/attachments/20090201/aaa61253/attachment.pgp