[Python-apps-team] Bug#750871: Bug 750871 - patch

[Javi Merino]

Control: tags -1 - pending + wontfix

On Sat, Jun 07, 2014 at 09:35:43PM +0100, Max Bowsher wrote:
> The problem here is that some manual sed hackery munging the /usr/bin/hg
> shebang was removed in PAPT SVN r10748, with the justification that
> dh_python2 would take care of it automatically.
> 
> Unfortunately, it was not considered that the package currently circumvents
> large portions of dh_python2's multiple python version support by calling
> the upstream Makefile instead of setup.py.

My guess is that the dh_python2 in sid doesn't have the problem
described in the bug, that's why I didn't see it.

> Fortunately the solution is relatively simple:
> 
> * Drop package-local Makefile constructs handling multiple python versions

True, that needs to be simplified.  It's been in my todo list for a
while now.

> * Explicitly call the python_distutils debhelper buildsystem plugin

No, this is not a good idea.

> * Use override hooks to call only the upstream Makefile targets which handle
> non-distutils parts of the build.

I don't want to replicate upstream's Makefile in debian/rules.  Today
this may mean calling "make doc" and "make tests" by hand but you
never know what can change in upstream's Makefile that will be lost
because we're not using it any more.  Mercurial is meant to be built
using the Makefile so calling distutils directly should be reduced to
the minimum.

Faheem, as I understand it, the backport version of the package will need
to reverse apply r10748 [1]

http://anonscm.debian.org/viewvc/python-apps/packages/mercurial/trunk/debian/rules?r1=10311&r2=10748&pathrev=10748

Cheers,
Javi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/python-apps-team/attachments/20140617/f0133a65/attachment.sig>