<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="">
<br>
</div>Thanks again for working on this.<br>
<br></blockquote><div>you´re welcome<br> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Your work is clearly based on the ‘python-daemon’ code, and that's<br>
good. But I am finding it difficult to follow:<br>
<br></blockquote><div>well, i tried to only stick to the pep, and not to do a refactor of the python-daemon implementation. but yes, i copied some parts, for example the doc string, because i was to lazy to type my own version of it. <br>
<br></div><div>to be honest, creating a daemon is no rocket science, the steps to do this are well defined, so there are not many ways to implement one.<br><br></div><div>but if you compare both DaemonContext.open() methods, you will notice that both do there work differently.<br>
<br></div><div>also, i did not implement the "runner" module as it is no part of the pep.<br></div><div>Â </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
* Can you please make a VCS history that *starts* with a known<br>
 revision from the official ‘python-daemon’ code, and makes<br>
 incremental changes from there. As it is, your code is quite<br>
 difficult to correlate with the current code base.<br>
<br></blockquote><div>I´am sorry, but i started from scratch with my implementation. i did not work on the python-daemon as a starting point<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
* You have removed copyright notices, which by the license terms you<br>
 are not permitted to do. This denies attribution to those whose work<br>
 you based yours on. Please restore the copyright notices as you<br>
 found them in the original code.<br>
<br></blockquote><div>the PSF-2 License is only allowed for projects that belong to the "Python Software Foundation" as i understand, the python-daemon is not part of the python standard libs. so choosing this licence was wrong in the first place, and is i understand, is not even allowed.<br>
<br></div><div>nevertheless, my intend was to publish pep3143daemon later under the MIT Licence, and i will also add a reference to the python-daemon package, with thanksgiving to the work that was done by all the other guys.<br>
<br></div><div>putting this on github that early, was only done, to share to code with you, to get some feedback.<br></div><div><br>i hope this will be okay for you.<br></div><div>Â </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
* You have re-structured the code into completely different locations<br>
 and filenames. These diverge from the upstream, and are also not<br>
 compliant with PEP 8. What is the reason for doing this? It makes<br>
 the code base difficult to compare, again.<br>
<br></blockquote><div>as i said, i started from scratch. but thank you for the hint with the file names, and method names. i already lower cased "PidFile.py" and "Daemon.py" and renamed some functions, like:<br>
<br></div><div>parentisinit() -> parent_is_init()<br></div><div>Â </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
If I could see the succession of changes starting from the official<br>
code base as a first revision in your repository, with explanations<br>
given in commit messages for each incremental change, that would make<br>
your work easier to examine. Thanks in advance!<br>
<span class=""></span></blockquote><div><br></div><div>i am really sorry, i do not have this.<br><br>cheers<br><br>stephan <br></div></div></div></div>