[Python-modules-team] Bug#540128: pyicu: FTBFS on GNU/kFreeBSD

[Cyril Brulebois]

Package: pyicu
Version: 0.8.1-3
Severity: important
Tags: patch
User: debian-bsd at lists.debian.org
Usertags: kfreebsd

Hi,

your package FTBFS due to:
 - missing platform detection. For that, see attached proposal for
   replacing platform-definitions-fix.dpatch, making it more general,
   and factorizing some bits of it (using a variable).
 - fragile debian/rules. It currently uses “$(DEB_BUILD_ARCH_OS)-$(shell
   uname -m)” but there's no guarantee that the pythonish build system
   is going to pick those. Use “ld” to find the full path (already done
   to list all tests). See second patch.

Didn't check linux2* archs, but any error should be obvious enough.

Thanks for considering.

Mraw,
KiBi.
-------------- next part --------------
--- pyicu-0.8.1/setup.py
+++ pyicu-0.8.1+kbsd/setup.py
@@ -34,25 +31,33 @@
     'win32': ['icuin', 'icuuc', 'icudt'],
 }
 
+my_platform = sys.platform
+# Linux is linux2-* on various platforms (#519099):
+if my_platform.startswith('linux2'):
+    my_platform = 'linux2'
+# GNU/kFreeBSD mostly behaves as GNU/Linux for userland:
+if my_platform.startswith('gnukfreebsd'):
+    my_platform = 'linux2'
+
 if 'PYICU_INCLUDES' in os.environ:
     _includes = os.environ['PYICU_INCLUDES'].split(os.pathsep)
 else:
-    _includes = INCLUDES[sys.platform]
+    _includes = INCLUDES[my_platform]
 
 if 'PYICU_CFLAGS' in os.environ:
     _cflags = os.environ['PYICU_CFLAGS'].split(os.pathsep)
 else:
-    _cflags = CFLAGS[sys.platform]
+    _cflags = CFLAGS[my_platform]
 
 if 'PYICU_LFLAGS' in os.environ:
     _lflags = os.environ['PYICU_LFLAGS'].split(os.pathsep)
 else:
-    _lflags = LFLAGS[sys.platform]
+    _lflags = LFLAGS[my_platform]
 
 if 'PYICU_LIBRARIES' in os.environ:
     _libraries = os.environ['PYICU_LIBRARIES'].split(os.pathsep)
 else:
-    _libraries = LIBRARIES[sys.platform]
+    _libraries = LIBRARIES[my_platform]
 
 
 setup(name="PyICU",
-------------- next part --------------
--- pyicu-0.8.1/debian/rules
+++ pyicu-0.8.1+kbsd/debian/rules
@@ -23,9 +23,9 @@
 	set -e ;\
 	for test in `ls test/*.py`; do \
 	  for py in $(PYVERS); do  \
-	    PYTHONPATH=$(CURDIR)/build/lib.$(DEB_BUILD_ARCH_OS)-$(shell uname -m)-$$py \
+	    PYTHONPATH=`ls -d $(CURDIR)/build/lib.*-*-$$py` \
 	      python$$py $$test ;\
-	    PYTHONPATH=$(CURDIR)/build/lib_d.$(DEB_BUILD_ARCH_OS)-$(shell uname -m)-$$py \
+	    PYTHONPATH=`ls -d $(CURDIR)/build/lib_d.*-*-$$py` \
 	      python$$py-dbg $$test ;\
 	  done ;\
 	done