[Qa-jenkins-scm] [Git][qa/jenkins.debian.net][master] reproducible Debian: write a longer mail to notify maintainers of their new unrep packages

[Mattia Rizzolo]

Mattia Rizzolo pushed to branch master at Debian QA / jenkins.debian.net


Commits:
5b07571c by Mattia Rizzolo at 2020-09-05T15:10:49+02:00
reproducible Debian: write a longer mail to notify maintainers of their new unrep packages

I had a case of such mail being marked as spam, mostly due to the
too-low whitespace ration and the whole body being only an URL.

This might improve deliverability to others as well, besides stop being
boarderline for my own spamassassin.

|Content preview:  2020-05-23 22:24 https://tests.reproducible-builds.org/debian/unstable/i386/acmetool
|   changed from reproducible -> FTBR
|
|Content analysis details:   (5.0 points, 5.0 required)
|
| pts rule name              description
|---- ---------------------- --------------------------------------------------
|-0.5 BAYES_05               BODY: Bayes spam probability is 1 to 5%
|                            [score: 0.0112]
| 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
|                            mail domains are different
| 1.1 LOCALPART_IN_SUBJECT   Local part of To: address appears in
|                            Subject
| 0.0 SPF_NONE               SPF: sender does not publish an SPF Record
| 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
| 0.0 TVD_SPACE_RATIO        No description available.
| 1.0 BODY_URI_ONLY          Message body is only a URI in one line of text or
|                            for an image
| 0.7 SUBJ_OBFU_PUNCT_FEW    Possible punctuation-obfuscated Subject:
|                            header
| 2.4 TVD_SPACE_RATIO_MINFP  Space ratio

Signed-off-by: Mattia Rizzolo <mattia at debian.org>

- - - - -


1 changed file:

- bin/reproducible_maintenance.sh


Changes:

=====================================
bin/reproducible_maintenance.sh
=====================================
@@ -784,13 +784,29 @@ if [ "$HOSTNAME" = "$MAINNODE" ] && [ $(date -u +%H) -eq 0 ]  ; then
 	cd $REP_RESULTS/notification-emails
 	for NOTE in $(find . -type f) ; do
 			TMPFILE=$(mktemp --tmpdir=$TEMPDIR maintenance-XXXXXXXXXXXX)
-			PKG=$(basename $NOTE)
-			mv $NOTE $TMPFILE
-			cat $TMPFILE | mail -s "$PKG: status change on tests.reproducible-builds.org/debian" \
-				-a "From: Reproducible builds folks <reproducible-builds at lists.alioth.debian.org>" \
+			MAILBODY=$(mktemp --tmpdir=$TEMPDIR maintenance-XXXXXXXXXXXX)
+			PKG=$(basename "$NOTE")
+			mv "$NOTE" "$TMPFILE"  # prevent races while running this routing and building this package.
+			cat > "$MAILBODY" <<- EOF
+			Dear maintainer,
+
+			The reproducibility status of the package $PKG changed during the
+			continuous testing.
+			See the following notes for more details:
+
+			$(< "$TMPFILE")
+
+			Feel free to reply to this email if you have questions regarding
+			this automatic notification.
+
+			-- 
+			The Reproducible Builds folks
+			EOF
+			< "$MAILBODY" mail -s "$PKG: status change on tests.reproducible-builds.org/debian" \
+				-a "From: Reproducible Builds folks <reproducible-builds at lists.alioth.debian.org>" \
 				-a "X-Reproducible-Builds-Pkg: $PKG" \
-				 $PKG at packages.debian.org
-			rm -f $TMPFILE
+				"$PKG at packages.debian.org"
+			rm -f "$TMPFILE" "$MAILBODY"
 	done
 fi
 



View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/-/commit/5b07571c7e62d70289dc99577e4691e44e1dd745

-- 
View it on GitLab: https://salsa.debian.org/qa/jenkins.debian.net/-/commit/5b07571c7e62d70289dc99577e4691e44e1dd745
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/qa-jenkins-scm/attachments/20200905/138e8d2a/attachment-0001.html>