[Reportbug-maint] Bug#222621: querybts: Could provide option to

chaica at ohmytux.com chaica at ohmytux.com
Mon Jul 27 17:25:34 UTC 2009


Hi Sandro,

Le lundi 27 juillet 2009 à 15:19 +0200, Sandro Tosi a écrit :
> Hi Carl,
> thanks a lot for the patch (as usual)!
> 
> On Thu, Jul 23, 2009 at 23:44, Carl Chenet<chaica at ohmytux.com> wrote:
> > Package: reportbug
> > Version: 4.5
> > Severity: normal
> > Tags: patch
> >
> > Hi,
> >
> > Here is a patch to allow "querybts --buglist package" to provide a list of the bugs for the given package.
> 
> just one clarification, in :
> 
> @@ -142,6 +147,9 @@ def main():
>          sys.exit(1)
> 
>      if use_browser:
> +        if use_browser and buglist:
> +            print "--mbox and --web won't work together."
> +            sys.exit(1)
>          package = args[0]
>          m = re.match('^#?(\d+)$', package)
>          if m:
> @@ -153,6 +161,9 @@ def main():
>          return
> 
This hunk above is to ensure the buglist option and the use_browser
option won't be used together, because there is no point about it. But I
don't see why I told "--mbox and --web won't work together.", it should
be "--web and --buglist won't work together."
 
>      if mbox:
> +        if mbox and buglist:
> +            print "--mbox and --buglist won't work together."
> +            sys.exit(1)
>          for bugnum in args:
>              m = re.match('^#?(\d+)$', bugnum)
>              if not m:
> 
> the first hunk is unrelated to the introduction of --buglist, and you
> added it because it needs to be fixed anyhow, right?
> 
> Cheers,

Thanks for double-checking.

Bye,
Carl Chenet






More information about the Reportbug-maint mailing list