[Reportbug-maint] Bug#488071: reportbug: No error message on missing attachment (curses frontend)

Sandro Tosi morph at debian.org
Mon Jan 4 17:58:42 UTC 2010


Analysis of the problem:

- UI: urwid
- in bin/reportbug we have:

        if x in ('a', 'i'):
            invalid = True
            while invalid:
                if x == 'i':
                    attachfile = ui.get_filename('Choose a text file
to include: ')
                else:
                    attachfile = ui.get_filename('Choose a file to attach: ')
                if attachfile:
                    attachfile = os.path.expanduser(attachfile)
                    if os.access(attachfile, os.R_OK) and
os.path.isfile(attachfile):
                        invalid = False
                        inline = (x == 'i')
                        (message, filename, attachments) =
include_file_in_report(
                            message, filename, attachments, package,
                            attachfile, charset, inline=inline)
                        if not inline:
                            skip_editing = True
                    else:
                        ui.display_failure("Can't find %s to
include!\n", attachfile)
                else:
                    break

that, in case the file is not found, it calls ui.display_failure().

- for urwid we have:

display_failure = ewrite

and, in fact, the messages are written to the console "in the
background" of the urwid UI (they are visible if you Ctrl+c or at exit
time).

-- 
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi





More information about the Reportbug-maint mailing list