Bug#1015246: zeal: please make the build reproducible

[Chris Lamb]

Source: zeal
Version: 1:0.6.1+git20220714+6fee23-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
zeal could not be built reproducibly.

This is because it adds a "development release" date to an XML file:

│ │ │ │ ├── ./usr/share/metainfo/org.zealdocs.zeal.appdata.xml
│ │ │ │ │ @@ -23,15 +23,15 @@
│ │ │ │ │        <image>https://i.imgur.com/qBkZduS.png</image>
│ │ │ │ │      </screenshot>
│ │ │ │ │    </screenshots>
│ │ │ │ │    <provides>
│ │ │ │ │      <id>zeal.desktop</id>
│ │ │ │ │    </provides>
│ │ │ │ │    <releases>
│ │ │ │ │ -    <release date="2022-07-15" version="0.6.2-dev" type="development"/>
│ │ │ │ │ +    <release date="2022-07-16" version="0.6.2-dev" type="development"/>

Patch attached that simply drops this line.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/reproducible-build.patch	2022-07-18 11:47:48.221289879 +0100
@@ -0,0 +1,18 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2022-07-18
+
+--- zeal-0.6.1+git20220714+6fee23.orig/CMakeLists.txt
++++ zeal-0.6.1+git20220714+6fee23/CMakeLists.txt
+@@ -44,11 +44,6 @@ endif()
+ 
+ set(ZEAL_VERSION_FULL "${Zeal_VERSION}${ZEAL_VERSION_SUFFIX}")
+ 
+-# For development builds insert an extra release in the AppStream metadata.
+-if(NOT RELEASE_VERSION)
+-    string(TIMESTAMP ZEAL_APPSTREAM_DEV_RELEASE "\n    <release date=\"%Y-%m-%d\" version=\"${ZEAL_VERSION_FULL}\" type=\"development\" />")
+-endif()
+-
+ # A custom target to print the full version.
+ # Usage: cmake --build build --target zeal_version
+ add_custom_target(zeal_version
--- a/debian/patches/series	2022-07-18 11:36:13.167186089 +0100
--- b/debian/patches/series	2022-07-18 11:47:47.389286997 +0100
@@ -1,2 +1,3 @@
 disable-check-for-update.patch
 #system-cpp-httplib.patch # only needed with the next upstream release
+reproducible-build.patch