[Reproducible-builds] Bug#778641: closed by Jérémy Bobbio <lunar at debian.org> (Bug#778641: fixed in debbindiff 11)

Helmut Grohne helmut at subdivi.de
Tue Mar 24 20:48:33 UTC 2015


Control: reopen -1
Control: severity -1 important

Raising severity to important as it now fails for way more invocations
than initially (i.e. I no longer find any successful input).

On Mon, Mar 23, 2015 at 09:21:13PM +0000, Debian Bug Tracking System wrote:
>    * Error out when encoding is not Unicode-compatible for text output.
>      (Closes: #778641)

I'm sorry to reopen again, but your fix is bogus.

1) debbindiff already forces LC_CTYPE=C.UTF-8. Setting LC_CTYPE in any
   way has absolutely no effect on debbindiff. The error message is
   wrong.

2) The error message claims that a non-utf8 console would be a problem,
   even when the output is directed to a file and nothing is written to
   the console.

3) When the except block issuing the error is discarded, one obtains the
   following more useful traceback:

Traceback (most recent call last):
  File "/usr/bin/debbindiff", line 119, in <module>
    sys.exit(main())
  File "/usr/bin/debbindiff", line 113, in main
    output_text(differences, print_func=print_func)
  File "/usr/lib/python2.7/dist-packages/debbindiff/presenters/text.py", line 70, in output_text
    print_details(difference, print_func)
  File "/usr/lib/python2.7/dist-packages/debbindiff/presenters/text.py", line 54, in print_details
    print_func(u"### %s" % detail.source1)
  File "/usr/bin/debbindiff", line 67, in print_func
    print(*args, **kwargs)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-2: ordinal not in range(128)

Here detail1.source1 == "control.tar.gz" (a str, not unicode).

I am seriously wondering whether fixing this properly is the best way
forward. The continued unavailability of debbindiffs from rebootstrap is
unfortunate. Maybe you can still apply the patch originally sent to
this bug report to make it just work?

Helmut



More information about the Reproducible-builds mailing list