Bug#876901: QFINDTESTDATA uses __FILE__

Holger Levsen holger at layer-acht.org
Mon Nov 13 18:56:39 UTC 2017


control: severity -1 wishlist

On Mon, Nov 13, 2017 at 07:15:44PM +0100, Pino Toscano wrote:
> Exactly, this is the source of the problem.  OTOH, the problem was
> created by changing __FILE__: it has a well-defined meaning:
> https://gcc.gnu.org/onlinedocs/cpp/Standard-Predefined-Macros.html
> changing this behaviour is only going to create problems, because
> people rely on such well-defined (and standard) behaviours.
[...] 
> No, the solution is:
> a) *not* break what __FILE__ means
> b) remove the misuses of __FILE__ in packages (not the case of
>    QFINDTESTDATA)
[...]
> What I see it is happening here is: you (= people working on
> reproducible builds) see __FILE__, and the problems that arise from its
> abuse; to overcome this issue, you use the sledgehammer solution,
> basically changing what __FILE__ means, and thus breaking even valid
> use cases.  Sorry, but I do not see how this is useful.
> 
> A better approach here is to work on removing the invalid & abusing
> usages of __FILE__ from packages, just like it was done for __DATE__.

downgrading the severity based on this.


-- 
cheers,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20171113/1d996e12/attachment.sig>


More information about the Reproducible-builds mailing list