Bug#876901: QFINDTESTDATA uses __FILE__

Ximin Luo infinity0 at debian.org
Tue Nov 14 11:14:00 UTC 2017


Pino Toscano:
> [..]
> 
>> Well let's take a look at the standards:
>> [...]
> 
> Even with different wordings, both describe basically the same
> behaviour.  And yes, none of them says that __FILE__ is a full path,
> but surely for relative paths the combination of $srcdir + __FILE__
> will give me the path to the source.
> 

Whatever, I don't care about having such a pointless long discussion. You're using __FILE__ inappropriately, none of the documentation guarantees or implies that you can access __FILE__ as a real filesystem path. "Surely for relative paths" is your justification for your own broken behaviour.

And that's just for GCC, IBM and Microsoft both use the term "name of the file" which don't even suggest any sort of path.

You can either accept my one line patch suggestion, or fix it some other way. I'm not going to change the GCC patch, it does nothing wrong.

Not going to spend any more time on this.

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git



More information about the Reproducible-builds mailing list