From helmut at subdivi.de Sun Jan 14 19:10:44 2018 From: helmut at subdivi.de (Helmut Grohne) Date: Sun, 14 Jan 2018 20:10:44 +0100 Subject: [Resolvconf-devel] Bug#887176: resolvconf should depend on e2fsprogs explicitly Message-ID: <20180114191043.GA19215@alf.mars> Package: resolvconf Version: 1.79 User: helmutg at debian.org Usertags: nonessentiale2fsprogs Dear maintainer, We want to make removing e2fsprogs from installations possible. For standard installations this is not useful, but embedded applications and chroots benefit from such an option. For getting there all packages that use e2fsprogs must be identified and gain a dependency on it as e2fsprogs currently is essential. resolvconf was identified as potentially needing such a dependency, because it mentions tool names from e2fsprogs in the following files: /usr/share/resolvconf/dump-debug-info contains lsattr. According to file it is a POSIX shell script, ASCII text executable DEBIAN/postinst contains chattr and lsattr. According to file it is a POSIX shell script, ASCII text executable Please investigate whether these cases are actually uses of a tool from e2fsprogs. Care has been taken to shrink the number of candidates as much as possible, but a few false positives will remain. After doing so, do one of the following: * Add e2fsprogs to Depends. * Add e2fsprogs to Recommends. * Close this bug explaining why e2fsprogs is not used by this package. Once e2fsprogs drops the "Essential: yes" flag, this bug will be upgraded to RC severity. Please note that lintian will warn about such a dependency before lintian 2.5.56. Thanks for your help Helmut From andreas at fatal.se Sat Jan 20 00:41:56 2018 From: andreas at fatal.se (Andreas Henriksson) Date: Sat, 20 Jan 2018 01:41:56 +0100 Subject: [Resolvconf-devel] Bug#887176: resolvconf should depend on e2fsprogs explicitly In-Reply-To: <20180114191043.GA19215@alf.mars> References: <20180114191043.GA19215@alf.mars> <20180114191043.GA19215@alf.mars> Message-ID: <20180120004156.i7vjlkeqzy2i66xx@fatal.se> Hello, On Sun, Jan 14, 2018 at 08:10:44PM +0100, Helmut Grohne wrote: > Package: resolvconf [...] > /usr/share/resolvconf/dump-debug-info contains lsattr. According to file it is a POSIX shell script, ASCII text executable This one uses lsattr, but guards the execution with checking if it exists first, so no strict dependency needed for this. Basing my assumption on the file name a Suggests would likely be more warranted than a Recommends. > DEBIAN/postinst contains chattr and lsattr. According to file it is a POSIX shell script, ASCII text executable [...] The postinst maintainerscript does indeed use both chattr and lsattr. Both of them are guarded with the debconf variable resolvconf/linkify-resolvconf having to be TRUE, which is the default. A dependency is thus currently needed here! An alternative approach if there's a reason to consider avoiding adding a strict dependency would be to refactor the debian/config to check for chattr/lsattr existance and if they're not available force the debconf variable resolvconf/linkify-resolvconf to false (likely together with a debconf prompt stating that). I'm not sure if the extra complexity is worth it and it would be great if maintainer(s) could comment on this. My conclusion is that a e2fsprogs dependency is likely the best solution. Regards, Andreas Henriksson From jdthood at gmail.com Fri Jan 26 15:14:01 2018 From: jdthood at gmail.com (Thomas Hood) Date: Fri, 26 Jan 2018 15:14:01 +0000 Subject: [Resolvconf-devel] Bug#887176: Bug#887176: resolvconf should depend on e2fsprogs explicitly In-Reply-To: <20180120004156.i7vjlkeqzy2i66xx@fatal.se> References: <20180114191043.GA19215@alf.mars> <20180120004156.i7vjlkeqzy2i66xx@fatal.se> <20180114191043.GA19215@alf.mars> Message-ID: Hi there, Is there any special reason not to add e2fsprogs as a dependency? Cheers, Thomas On Sat, 20 Jan 2018 at 01:45 Andreas Henriksson wrote: > Hello, > > On Sun, Jan 14, 2018 at 08:10:44PM +0100, Helmut Grohne wrote: > > Package: resolvconf > [...] > > /usr/share/resolvconf/dump-debug-info contains lsattr. According to file > it is a POSIX shell script, ASCII text executable > > This one uses lsattr, but guards the execution with checking if it > exists first, so no strict dependency needed for this. Basing my > assumption on the file name a Suggests would likely be more warranted > than a Recommends. > > > DEBIAN/postinst contains chattr and lsattr. According to file it is a > POSIX shell script, ASCII text executable > [...] > > The postinst maintainerscript does indeed use both chattr and lsattr. > Both of them are guarded with the debconf variable > resolvconf/linkify-resolvconf having to be TRUE, which is the default. > A dependency is thus currently needed here! > > An alternative approach if there's a reason to consider avoiding adding > a strict dependency would be to refactor the debian/config to check > for chattr/lsattr existance and if they're not available force the > debconf variable resolvconf/linkify-resolvconf to false (likely together > with a debconf prompt stating that). I'm not sure if the extra > complexity is worth it and it would be great if maintainer(s) could > comment on this. > > My conclusion is that a e2fsprogs dependency is likely the best > solution. > > Regards, > Andreas Henriksson > > _______________________________________________ > Resolvconf-devel mailing list > Resolvconf-devel at lists.alioth.debian.org > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/resolvconf-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: