[sane-devel] sceptre backend

[Henning Meier-Geinitz]

Hi,

On Wed, Feb 20, 2002 at 01:10:23PM -0600, Frank Zago wrote:
> Can somebody review my sceptre backend and integrate it to the cvs tree
> if it's correct?

I'm impressed. You even patched AUTHORS and DISTFILES in Makefile.in :-)

Ok, looking at sceptre.c:

* better use #include "../include/sane/*" for the sane headers. It's
  not really necessary but makes clear that the local headers are used
  and not the ones that may be already installed.
* assert can make trouble on AIX. The easiest way is to avoid it.
  Otherwise, please use the internal "lassert.h" header (see e.g.
  sanei_scsi.c).
* there are some warnings about signed/unsigned. i don't know if they
  are a problem but it should be possible to fix them with casts.
* the coding style isn't quite GNU (see backend-writing.txt). I'm not
  that strict about this and there might be other opinions but I think
  same/similar coding style is a good thing (tm). indent should be able to
  "fix" it.

Concerning sceptre.conf:
* Don't you want to add a "scsi vendor product" line? This allows
  auto-detection at least on Linux, even if there is no /dev/scanner link.
  sanei_config_attach_matching_devices does all the magic.

Sceptre.desc: 
* version number is without brackets when the backend is included into
  CVS
* version number should represent the version that's returned to
  sane_init (something like 1.0.5).
* status is :NEW after the inclusion until after the first release
  that includes your backend
* what does "hardware KINPO" mean? This is in the SCSI inquiry? Is
  this an alternative name? What about the "Vividscan"? If it's part
  of the official name, maybe you can add it also to sceptre.desc so
  people searching for it can find the pagge?

doc/Makefile.in:
* add sceptre (the directory) to BACKDIRS

I have tested compilation on AIX, Irix, Solaris and Linux. No problems
during compilation, but running on AIX fails because of the assert
problem mentioned above.

It would be nice if someone else could have a look at the backend.

Bye,
  Henning