[sane-devel] Bug in scanimage.c + Patch

[Klaas Freitag]

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime@docserver.cac.washington.edu for more info.

--168468480-246656263-1016641658=:13456
Content-Type: TEXT/PLAIN; charset=US-ASCII


Hi,

I think there is a small bug in the code handling the -f option. IMHO it mallocs
a one byte to small buffer for a strcpy action. I could reproduce some crashes
which disappeared after having applied the attached patch.

If you agree, please apply the patch.

Regards,

Klaas


-- 
 ----------------------------------------------------------------------
 Ja mach nur einen Plan und sei ein grosses Licht         Klaas Freitag
 dann mach noch einen zweiten Plan    *            mail freitag@suse.de
 gehn tun sie beide nicht. - B. Brecht             SuSE Labs, Nuernberg
 ----------------------------------------------------------------------

--168468480-246656263-1016641658=:13456
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="scanimage.diff"
Content-Transfer-Encoding: BASE64
Content-Description: Patch
Content-Disposition: attachment; filename="scanimage.diff"

LS0tIHNjYW5pbWFnZS5vcmlnLmMJV2VkIE1hciAyMCAxNzoxMjoxMSAyMDAy
DQorKysgc2NhbmltYWdlLmMJV2VkIE1hciAyMCAxNzoxMjo0MSAyMDAyDQpA
QCAtMTUwMSw3ICsxNTAxLDcgQEANCiAJICAgICAgICAgICAgZXhpdCgxKTsN
CiAJICAgICAgICAgIH0NCiAJICAgICAgICANCi0JICAgICAgICBmbXQgPSBt
YWxsb2Moc3RybGVuKG9wdGFyZykpOw0KKwkgICAgICAgIGZtdCA9IHN0cmR1
cChvcHRhcmcpOw0KIAkgICAgICAgIGlmIChmbXQgPT0gMCkNCiAJICAgICAg
ICAgIHsNCiAJICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICIlczogbm90
IGVub3VnaCBtZW1vcnlcbiIsIHByb2dfbmFtZSk7DQpAQCAtMTUxMSw3ICsx
NTExLDYgQEANCiAJICAgICAgICBmb3IgKGkgPSAwOyBkZXZpY2VfbGlzdFtp
XTsgKytpKQ0KIAkgICAgICAgICAgew0KIAkgICAgICAgICAgICBuID0gMDsN
Ci0JICAgICAgICAgICAgc3RyY3B5KGZtdCwgb3B0YXJnKTsNCiAJICAgICAg
ICAgICAgc3RhcnQgPSBmbXQ7DQogCSAgICAgICAgICAgIHdoaWxlKCAocGVy
Y2VudCA9IHN0cmNocihzdGFydCwgJyUnKSkgKQ0KIAkgICAgICAgICAgICAg
IHsNCg==
--168468480-246656263-1016641658=:13456--