[sane-devel] Nikon CoolScan IV and next sane release

[Henning Meier-Geinitz]

Hi,

On 2006-05-08 08:51, Giuseppe Sacco wrote:
> It was posted to this list on the 27th october 2005 by Ariel Garcia,
> here it is. There were some mail with comments on about the C code on
> that thread.

I've just  forwarded the patch again to the backend maintainer.

Let's try:
coolscan2.c: In function 'sane_coolscan2_read':
coolscan2.c:1523: error: syntax error before '/' token
coolscan2.c:1525: error: 'i' undeclared (first use in this function)
[...]

Ok, "illegal" "//" comments. Fixed.

coolscan2.c: In function 'sane_coolscan2_read':
coolscan2.c:1524: warning: ISO C90 forbids mixed declarations and code

Fixed now.

More comments:

> +      sanei_usb_attach_matching_devices ("usb 0x04b0 0x4001", cs2_attach);
> +      sanei_usb_attach_matching_devices ("usb 0x04b0 0x4002", cs2_attach);

Which scanner is id 0x4002? According to our lists, it's the "Super
Coolscan LS-5000 ED". Does this also work?

> @@ -2324,14 +2352,14 @@
>    s->resx_max = 256 * s->recv_buf[20] + s->recv_buf[21];
>    s->resx_min = 256 * s->recv_buf[22] + s->recv_buf[23];
>    s->boundaryx =
> -    65536 * (s->recv_buf[36] + 256 * s->recv_buf[37]) +
> +    65536 * (256 * s->recv_buf[36] + s->recv_buf[37]) +
>      256 * s->recv_buf[38] + s->recv_buf[39];

Well, I don't know nothing abot that backend but wouldn't this break
the already existing scanners?

>    s->resy_optical = 256 * s->recv_buf[40] + s->recv_buf[41];
>    s->resy_max = 256 * s->recv_buf[42] + s->recv_buf[43];
>    s->resy_min = 256 * s->recv_buf[44] + s->recv_buf[45];
>    s->boundaryy =
> -    65536 * (s->recv_buf[58] + 256 * s->recv_buf[59]) +
> +    65536 * (256 * s->recv_buf[58] + s->recv_buf[59]) +
>      256 * s->recv_buf[60] + s->recv_buf[61];

Same here.
Just to be sure, use 
if ((s->type == CS2_TYPE_LS50) || (s->type == CS2_TYPE_LS5000))
here?

Bye,
  Henning