[sane-devel] [RFC][PATCH] sanei configuration framework extension

m. allan noah kitno455 at gmail.com
Mon Jul 7 20:25:34 UTC 2008


2008/6/25 stef <stef.dev at free.fr>:
>        here's the patch modified like you suggest. Now both descriptors and
> placeholders are given by the backend. There is no need for a free'ing
> function anymore.

this looks very good, but i dont see much point in the helper
functions. presumably the backend will maintain some sort of enum list
of indexes (like most do with options), so it wont need to lookup by
name, and the initializer would probably be fewer lines of code if
done inside the backend, and you wont need the descriptor array to be
null terminated.

oh, and what about a backend that has only option lines in the config
file, it would never call the callback. i guess the backend can still
read the SANEI_Config structure pointer if it cached it somewhere,
after calling sanei_configure_attach()?

allan
-- 
"The truth is an offense, but not a sin"



More information about the sane-devel mailing list