[sane-devel] Anybody with access to Pixma MP160 or MP780? [was: Re: Pixma MP600 broken by 1430217e1919801fa6418c36589cc4360e5f1779] (fwd)

Tomas Pospisek tpo_deb at sourcepole.ch
Fri Dec 17 22:27:55 UTC 2010


On Thu, 16 Dec 2010, Gernot Hassenpflug wrote:

> On Wed, Dec 15, 2010 at 7:56 PM, Tomas Pospisek <tpo_deb at sourcepole.ch> wrote:
>> Hello Nicolas (and List),
>>
>> any chance we could get the Canon Pixma Generation #2 fix into the pixma
>> backend?
>> *t
>
> Just one comment (I will only be able to test the MP810 this Saturday):
>
> Since the code, I believe, is in a condition that is <= generation 2,
> the code line that had the exceptions for individual generation 2
> machines should have the exception line changed to check == generation
> 2. In other words, generation 1 machines I think need to be excluded.

So the patch would be:

diff --git a/backend/pixma_mp150.c b/backend/pixma_mp150.c
index ebee20c..fbcca2e 100644
--- a/backend/pixma_mp150.c
+++ b/backend/pixma_mp150.c
@@ -676,7 +676,7 @@ send_scan_param (pixma_t * s)
        pixma_set_be16 (s->param->xdpi | 0x8000, data + 0x04);
        pixma_set_be16 (s->param->ydpi | 0x8000, data + 0x06);
        pixma_set_be32 (s->param->x, data + 0x08);
-      if (s->cfg->pid == MP460_PID || s->cfg->pid == MP510_PID)
+      if (mp->generation == 2)
          pixma_set_be32 (s->param->x - s->param->xs, data + 0x08);
        pixma_set_be32 (s->param->y, data + 0x0c);
        pixma_set_be32 (raw_width, data + 0x10);

*t

>> ---------- Forwarded message ----------
>> Date: Wed, 15 Dec 2010 09:37:21 +0900
>> From: Gernot Hassenpflug
>> To: Tomas Pospisek
>> Subject: Re: Anybody with access to Pixma MP160 or MP780? [was: Re:
>> [sane-devel]
>>     Pixma MP600 broken by 1430217e1919801fa6418c36589cc4360e5f1779]
>>
>> On Wed, Dec 15, 2010 at 6:30 AM, Tomas Pospisek wrote:
>>>
>>> Hello Gernot,
>>>
>>> any chance to get this change in before Debian releases (which I guess
>>> will
>>> be over this holidays...)?
>>> *t
>>
>> Hi Tomas,
>>
>> I don't know if you meant to send the mail to Nicolas instead of to
>> me, as he is the maintainer of the Canon backend in SANE.
>>
>> I have to still unpack the MP810 for testing, after I send off two
>> boxes tonight I should have space in my room to do that.
>>
>> Best regards,
>> Gernot Hassenpflug
>>
>>> On Tue, 7 Dec 2010, Tomas Pospisek wrote:
>>>
>>>> On Tue, 7 Dec 2010, Gernot Hassenpflug wrote:
>>>>
>>>>> On Tue, Dec 7, 2010 at 6:08 AM, Tomas Pospisek wrote:
>>>>>>
>>>>>> Is there anybody here, that could test that the proposed fix [1] makes
>>>>>> MP160
>>>>>> or MP780 or other Pixma generation#2 scanners [2] work again with the
>>>>>> current devel sane version?
>>>>>>
>>>>>> I've received a confirmation of another MP600 user, that the proposed
>>>>>> fix
>>>>>> [1] solves the scanning problem. Unfortunately I have not heard of any
>>>>>> other
>>>>>> Pixma generation#2 users.
>>>>>>
>>>>>> I'd be very happy if this fix could make it into the backend and into
>>>>>> Debian
>>>>>> Squeeze.
>>>>>>
>>>>>> *t
>>>>>>
>>>>>> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=585887#85
>>>>>> [2] MP160, MP180, MP460, MP510, MP600R, MP810, MP960, MP140
>>>>>
>>>>> I have an MP810 and MP960 that I can test.
>>>>>
>>>>> Please give me a couple of days. Is this fix now in CVS (if not I can
>>>>> remove the exception from my own code).
>>>>
>>>> No, it's not in CVS (git) yet.
>>>> *t
>>>>
>>>
>>
>>
>>
>> --
>> ISP Asahi-Net: http://asahi-net.jp/en/
>> No.1 in Japan by customer satisfaction
>> (Nikkei News, 7 July 2010)
>>
>>
>
>
>
> -- 
> ISP Asahi-Net: http://asahi-net.jp/en/
> No.1 in Japan by customer satisfaction
> (Nikkei News, 7 July 2010)
>
>


More information about the sane-devel mailing list