[sane-devel] saned option handling changes (was Re: [PATCH v4 1/5] saned: parse standalone args in main())

Olaf Meeuwissen paddy-hack at member.fsf.org
Tue Oct 13 14:36:17 UTC 2015


Matteo Croce writes:

> Hi Olaf,
>
> great, but I think that commit 45e66aee is wrong because it's
> shadowing the global variable 'bind_addr'.

My bad.

> Also there is no need to initialize it to NULL because static
> variables are always set to 0.

I write a lot of C++.  There static variables are initialized by their
default constructor and I always forget what happens to POD-types.  I
normally prefer to be explicit.

Anyway, I've reverted the offending commit.

Hope this helps,
-- 
Olaf Meeuwissen, LPIC-2            FSF Associate Member since 2004-01-27
Support Free Software               Support the Free Software Foundation
https://my.fsf.org/donate                        https://my.fsf.org/join
 GnuPG key: F84A2DD9/B3C0 2F47 EA19 64F4 9F13  F43E B8A4 A88A F84A 2DD9



More information about the sane-devel mailing list