[sane-devel] [RFC] mksotemp

[Olaf Meeuwissen]

Alessandro Zummo writes:

> On Mon, 02 May 2016 11:57:58 +0900
> Olaf Meeuwissen <paddy-hack at member.fsf.org> wrote:
>
>> That leaves zero flags to be passed, so the mkostemp() call reduces to
>> mkstemp().
>> 
>> I would simply call mkstemp() unconditionally.  That way you also don't
>> have to add it to AC_CHEC_FUNCS() in configure.in anymore.
>
>  I agree with you, but not being the original
>  author I didn't want to remove it all :)  

Simplicity is a virtue.  There is no benefit in making the code more
convoluted than necessary.  Just call mkstemp() unconditionally.  If
you write a commit message that documents the rationale, I doubt the
original author will complain.

Hope this helps,
-- 
Olaf Meeuwissen, LPIC-2            FSF Associate Member since 2004-01-27
 GnuPG key: F84A2DD9/B3C0 2F47 EA19 64F4 9F13  F43E B8A4 A88A F84A 2DD9
 Support Free Software                        https://my.fsf.org/donate
 Join the Free Software Foundation              https://my.fsf.org/join