[sane-devel] [umax_pp] Fix unused-but-set-parameter compiler warning

Stef stef.dev at free.fr
Mon Sep 5 04:04:23 UTC 2016


On 30/08/2016 14:21, Olaf Meeuwissen wrote:
> Stef writes:
>
>> On 28/08/2016 08:57, Olaf Meeuwissen wrote:
>>> Hi Stef,
>>>
>>> The umax_pp_low.c file's offsetCalibration1220p() defines and optionally
>>> modifies the opsc10 variable but that variable isn't used anywhere else.
>>> Is there any particular reason to do so?  Like, maybe, it should have
>>> been used in that function for something?  If not, I'll go ahead and
>>> remove it.
>>>
>>> Hope this helps,
>> Hello,
>>
>> it is used via the macro `CMDSETGET (1, 0x08, opsc10);` line 12624.
> That's in coarseGainCalibration1220p().  The one I'm talking about is
> defined at line 11902 and optionally modified at lines 11929-11932 in
> offsetCalibration1220p().  That function ends at line 12073.
>
> Sorry for not being clear.

Hello,

sorry for the delay. Yes that one can be removed. It is an unused 
duplicate of opsc04 in coarseGainCalibration().

Regards,

     Stef




More information about the sane-devel mailing list