[sane-devel] [PATCH v3] Swap bytes in 16-bit PNGs, because PNG is big-endian.

[Olaf Meeuwissen]

Hi Aaron,

Sorry for not reading your whole thread before replying ;-)

Aaron Muir Hamilton writes:

> Sorry about the volume, third time is definitely the charm.
> Admittedly I struggled to grasp the style rules.

Style rules?  If there are any, they're at a per file basis AFAICS :-(
Which reminds me, I should exempt the SANE code from my EditorConfig[1]
default settings.

 [1] http://editorconfig.org/

> I noticed the PNG byte order issue fixed by this patch when using
> genesys with a CanoScan LiDE 220. I do not have any other supported
> scanners close at hand, so I hope somebody can confirm if this is an
> issue specific to genesys. The TIFF 16-bit output already worked
> correctly since TIFF is happy to be little-endian.

Correct, TIFF supports any byte order so long as you tell it which one
you're using.  Whether all TIFF reader support that is another issue.

Hope this helps,
--
Olaf Meeuwissen, LPIC-2            FSF Associate Member since 2004-01-27
 GnuPG key: F84A2DD9/B3C0 2F47 EA19 64F4 9F13  F43E B8A4 A88A F84A 2DD9
 Support Free Software                        https://my.fsf.org/donate
 Join the Free Software Foundation              https://my.fsf.org/join