<div class="gmail_quote">2010/11/30 Gernot Hassenpflug <span dir="ltr"><<a href="mailto:aikishugyo@gmail.com">aikishugyo@gmail.com</a>></span><br>
<blockquote style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex" class="gmail_quote">
<div class="im">On Tue, Nov 30, 2010 at 5:53 AM, Nicolas Martin<br><<a href="mailto:nicolas0martin@gmail.com">nicolas0martin@gmail.com</a>> wrote:<br>> Le lundi 29 novembre 2010 à 19:54 +0100, Tomas Pospisek a écrit :<br>
>> On Mon, 29 Nov 2010, Tomáš Pospíšek wrote:<br>>><br>>> [...]<br>>><br>>> The same patch seems also to have broken Canon Pixma MP160 [1] and Pixma<br>>> MP780 [2].<br>><br>> Could you try first to change, in the current git version of Sane, the<br>
> following line in backend/pixma_mp150.c, at line 683:<br>><br>> if (s->cfg->pid == MP460_PID || s->cfg->pid == MP510_PID)<br>> pixma_set_be32 (s->param->x - s->param->xs, data + 0x08);<br>
><br>> Take out the if condition, and leave only the second line:<br>><br>> pixma_set_be32 (s->param->x - s->param->xs, data + 0x08);<br><br><br></div>Hi Nicolas,<br>That is quite strange. This is one of the patches which I believe I<br>
submitted during testing of various scanners, including the MP760/780.<br>The MP460 and MP510 required a new addition (condition) which only<br>have applied to them (for now) and no other devices, so I do not<br>understand exactly how this affects unrelated devices. Unfortunately I<br>
now no longer have any of these machines, but I will compare the code<br>I still have.<br>Regards,<br><font color="#888888">Gernot Hassenpflug<br></font></blockquote>
<div> </div>
<div> </div>
<div>Originaly, the patch provided by Christian Scholtz for fine cropping adjustment, and uploaded in January 2010, was designed and tested on gen 3 devices, but I guess not on gen 2 devices, and was probably not working for any gen 2 devices. </div>
</div>
<div>You probably noticed it when testing MP460 and MP510, that's why you fixed the above line </div>
<div>(s->param->x - s->param->xs instead of s->param->x) but added a restriction for those 2 models. </div>
<div>I'm just guessing here this fix is necessary for any gen 2 device as well.</div>
<div> </div>
<div>nicolas<br></div>