<div dir="ltr">Hi Hans-Christoph,<div>       I have made changes as per your suggestions. <a href="https://github.com/SDkie/lildebi/commit/330d575df502d7f79951129f19a1048168747c37">here</a>[1] is the link of my </div><div>
latest commit. </div><div><br></div><div>[1] <a href="https://github.com/SDkie/lildebi/commit/330d575df502d7f79951129f19a1048168747c37">https://github.com/SDkie/lildebi/commit/330d575df502d7f79951129f19a1048168747c37</a></div>
<div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Apr 8, 2014 at 9:37 PM, Hans-Christoph Steiner <span dir="ltr"><<a href="mailto:hans@guardianproject.info" target="_blank">hans@guardianproject.info</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
Hey Kumar,<br>
<br>
Overall the patch looks good.  One comment about the code style.  It is<br>
important to match the code style of a project that you are contributing to.<br>
Things like using camelCase for names in Java code (i.e. fileSystemName<br>
instead of filesystem_name, or fileSystemType instead of filesystemtype).<br>
This makes the code more readible.<br>
<br>
Another is to use an automatic code formatter that matches the project.  This<br>
is important because any little change to the code can make merging and<br>
rebasing a lot more difficult.  When everyone uses the exact same code format,<br>
and it is done automatically, that minimizes trivial changes in commits, like<br>
whitespace, etc.<br>
<br>
So LilDebi uses the Android mode of the Eclipse formatter, but the default<br>
Eclipse formatter is fine.<br>
<br>
You can see the difference in lines like this:<br>
<br>
        public static String fileSystemType() {<br>
<br>
versus what you currently have:<br>
<br>
        public static String filesystemtype(){<br>
<br>
There are many other code formatters, so you can use any as long as it<br>
generates the same format.  astyle is another popular one that is a terminal<br>
program.<br>
<br>
.hc<br>
<div class=""><br>
On 04/07/2014 03:25 PM, Kumar Sukhani wrote:<br>
> Hi all,<br>
><br>
>     I am Kumar Sukhani, applying for the project 'Integrate Debian with<br>
> Android' for GSOC and link<br>
> of my proposal is<br>
</div>> here<<a href="https://wiki.debian.org/SummerOfCode2014/StudentApplications/Kumar%20Sukhani" target="_blank">https://wiki.debian.org/SummerOfCode2014/StudentApplications/Kumar%20Sukhani</a>><br>
<div class="">> [1]. In addition to that I have also submitted one<br>
</div>> patch<<a href="https://github.com/guardianproject/lildebi/pull/92" target="_blank">https://github.com/guardianproject/lildebi/pull/92</a>>[2]<br>
<div class="">> adding feature to<br>
> 'Limit image size to 4GB on FAT filesystems' for the<br>
</div>> issue#80<<a href="https://github.com/guardianproject/lildebi/issues/80" target="_blank">https://github.com/guardianproject/lildebi/issues/80</a>><br>
<div class=""><div class="h5">> [3]. Please reviews my proposal and<br>
> patch and suggest changes if any are required.<br>
><br>
> Currently I am going through the code of lil'debi and comparing the same<br>
> with similar project like<br>
> 1) linuxonandroid -<br>
> <a href="http://sourceforge.net/p/linuxonandroid/codegit/ci/master/tree/" target="_blank">http://sourceforge.net/p/linuxonandroid/codegit/ci/master/tree/</a><br>
> 2) cuntubuntu - <a href="https://github.com/pelya/cuntubuntu" target="_blank">https://github.com/pelya/cuntubuntu</a><br>
><br>
> Awaiting you reply.  Thanks in advance.<br>
><br>
> [1]<br>
> <a href="https://wiki.debian.org/SummerOfCode2014/StudentApplications/Kumar%20Sukhani" target="_blank">https://wiki.debian.org/SummerOfCode2014/StudentApplications/Kumar%20Sukhani</a><br>
> [2] <a href="https://github.com/guardianproject/lildebi/pull/92" target="_blank">https://github.com/guardianproject/lildebi/pull/92</a><br>
> [3] <a href="https://github.com/guardianproject/lildebi/issues/80" target="_blank">https://github.com/guardianproject/lildebi/issues/80</a><br>
><br>
> --<br>
> Kumar Sukhani<br>
><br>
<br>
</div></div><span class=""><font color="#888888">--<br>
PGP fingerprint: 5E61 C878 0F86 295C E17D  8677 9F0F E587 374B BE81<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br>Kumar Sukhani<br>+919579650250<br>
</div></div></div>