[Splashy-devel] 4a/6 Make simple interface for splashy_video.h
Pat Suwalski
pats at xandros.com
Mon Aug 14 14:01:19 UTC 2006
Tim Dijkstra wrote:
> [4/6 was to big for the list]
> Remove "splashy_video_t * video" from the functions argument list,
> make an instance of splashy_video_t local to splashy_video.c instead.
> That way the rest of splashy doesn't have to know about splashy_video_t
> at all.
Isn't this the sort of change that is opposite of how most projects
organize their code? I've always considered it good style to pass a
pointer to an "object" rather than have it globally-accessible...
The other patches look good.
--Pat
More information about the Splashy-devel
mailing list