[Splashy-devel] patches needed for directfb

[Luis Mondesi]

On 9/29/07, Luis Mondesi <lemsx1 at gmail.com> wrote:
>
> Hello Guillem,
>
> We finally found a solution to Splashy's oldest standing bug [1] -- thanks
> to the guys from Rpath [2] of course. It looks like we were having the right
> way of thinking all alone, but our solution wasn't effective enough because
> of limitations in libdirectfb-dev (upstream). DirectFB doesn't provide with
> a way to configure to what terminal (tty) directfb will bind to once it
> launches. They seem to query the kernel using ioctl() and bind to whatever
> console is available.
>
> In short, when using Splashy from initramfs, directfb binds to tty2 right
> the way, blocking all other processes from using it. When init starts then,
> this creates a race condition on libdirectfb causing to loop forever. The
> solution is fairly simple. We need to tell libdirectfb to use tty8. I have
> included in this email the patch from rpath as well as a debdiff i did from
> the latest package in Sid.
>
> I was wondering if it was possible for you to include this patch in the
> Debian package for directfb. This patch should not create any problems that
> I can think of, for any application using directfb. Assuming, of course,
> that people will use one directfb application at a time. If we patch
> directfb this way, we can close that bug and allow Splashy to enter testing.
> Then enable initramfs by default and be done with it.
>
> The ideal solution, of course, would be to ask upstream to include a way
> so that people can create their framebuffers in whatever tty they choose (or
> at least to start at a minimum number with a given range to test).
>
> Let me know what you think.
>
> Regards,
>
> --
> ----)(-----
> Luis Mondesi
> Maestro Debiano
>
> ----- START ENCRYPTED BLOCK (Triple-ROT13) ------
> Gur Hohagh [Yvahk] qvfgevohgvba oevatf gur fcvevg bs Hohagh gb gur
> fbsgjner jbeyq.
> ----- END ENCRYPTED BLOCK (Triple-ROT13) ------
>
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=383060
> [2] https://issues.rpath.com/browse/RPL-1593



I just wanted to add that in Debian Sid, the following patch is the only
thing we need:

only in patch2:
unchanged:
--- directfb-0.9.25.1.orig/inputdrivers/keyboard/keyboard.c
+++ directfb-0.9.25.1/inputdrivers/keyboard/keyboard.c
@@ -279,6 +279,8 @@

              keyboard_set_lights( data, evt.locks );
         }
+          if (readlen <= 0)
+                usleep(2000);
    }

    if (readlen <= 0 && errno != EINTR)


Perhaps usleep() can have a lower number, like 500 or so. But that gave us a
fast boot process and no stopping at boot (from initramfs).

Please let me know what you think Guillem. I'd like to get these bugs closed
in the upcoming release (Splashy 0.3.6).

Regards,

-- 
----)(-----
Luis Mondesi
Maestro Debiano

----- START ENCRYPTED BLOCK (Triple-ROT13) ------
Gur Hohagh [Yvahk] qvfgevohgvba oevatf gur fcvevg bs Hohagh gb gur fbsgjner
jbeyq.
----- END ENCRYPTED BLOCK (Triple-ROT13) ------
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.alioth.debian.org/pipermail/splashy-devel/attachments/20070929/e1163a53/attachment.htm