commit IDs in changelog messsages (was: Introductory mail)

martin f krafft madduck at debian.org
Fri Nov 14 06:47:06 UTC 2008


also sprach Petr Baudis <pasky at ucw.cz> [2008.11.13.1540 +0100]:
> On Thu, Nov 13, 2008 at 01:28:17PM +0100, Manuel Prinz wrote:
> > Am Donnerstag, den 13.11.2008, 12:54 +0100 schrieb Adeodato Simó:
> > > Though I agree with your reasoning here, I find (2) a tad too verbose
> > > (mostly because of the colon appearing twice, which requires two passes
> > > from your brain, if you see what I mean). May I suggest:
> > > 
> > >     3) (Closes: #1234567, Vcs-Git:fba134)
> > > 
> > > And Vcs-Hg, Vcs-Bzr, and so on. How does that sound?
> > 
> > I think this syntax is a good compromise and most packagers are familiar
> > with the notation from debian/control.
> > 
> > If it should be clear to someone outside of Debian (packaging), the
> > notation "{Git,SVN,Hg,*}-Commit" might also be reasonable, as it shows
> > that the entry has something to do with a VCS commit.
> 
> I'm a little bit confused, is this sub-thread Debian-specific or are you
> meaning to come up with some more general form? E.g. SUSE uses
> [bnc#456789] instead of (Closes: #456789) so maybe you would want to
> just keep the Vcs-Git:\x+ part, without further context specification.

We ought to try to set a standard and hope that Suse and RedHat etc.
adopt it. There is no context in the above, just like we do not
require 'Closes:' to appear in parentheses. The parser should be
able to filter out commit IDs even if they appear on lines of their
own, in the middle of the text ("did this, which closes: #123435,
and also makes the software better"), though admittedly for Vcs-Git,
this is not going to work.

In the long run, I really want to supersede "Closes:" anyway.
Ideally, the bug gets marked 'fix-committed' when a signed-off
commit closing the bug hits the repo (or a tag like closes-123456
appears), and an upload would identify bugs closed between the last
upload and this one, using the repo and those commit IDs, and then
selectively close those bugs.

-- 
 .''`.   martin f. krafft <madduck at debian.org>
: :'  :  proud Debian developer, author, administrator, and user
`. `'`   http://people.debian.org/~madduck - http://debiansystem.info
  `-  Debian - when you have better things to do than fixing systems
 
because light travels faster than sound,
some people appear to be intelligent,
until you hear them speak.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature (see http://martin-krafft.net/gpg/)
Url : http://lists.alioth.debian.org/pipermail/vcs-pkg-discuss/attachments/20081114/88092367/attachment.pgp 


More information about the vcs-pkg-discuss mailing list