[Vmdebootstrap-devel] Bug#770722: [Bug#770722]: add --debootstrap-opts to pass additional options to debootstrap

[Lars Wirzenius]

On Sun, May 03, 2015 at 08:36:32PM +0200, Jan Gerber wrote:
> Looking at the documentation of string_list/StringListSetting it is not
> clear to me why it has the additional comma parsing, it seams to combine 2
> modes:
>  - argument can be passed multiple times to pass multiple values
>    (--key foo --key bar)
>  - value is a list separated by comma
>    (--key "foo, bar")
> 
> my initial thought would be that settings.string_list should be one of those
> two modes not both. from the docs I would guess the first mode.

I agree that it should be only the first mode. The reason the comma
parsing on the command line is to be compatible with the parsing of
configuration files, but that's not a good reason. From an
implementation point of view, it was easier to use the same parsing
for option values and configuration file values.

> adding a simple string list without comma parsing could look like this:

I would prefer to fix StringList rather than invent a new, nearly
identical setting type. MultiString would still need to do the things
necessary to parse option values separately from a value from a
configuration file.

-- 
Happiness is a tested backup.