[debian-edu-commits] debian-edu/upstream/ 54/71: Avoid Popen() problem by throwing away unused output from subprocesses (Closes: #634829).

[Petter Reinholdtsen]

This is an automated email from the git hooks/post-receive script.

pere pushed a commit to branch master
in repository libpam-mklocaluser.

commit 33d9072ad03eab5b02950d46abb120e3b336b03d
Author: Petter Reinholdtsen <pere at hungry.com>
Date:   Tue Jul 26 10:51:05 2011 +0000

    Avoid Popen() problem by throwing away unused output from subprocesses (Closes: #634829).
---
 debian/changelog     | 7 +++++++
 debian/pam-python.py | 6 ++++--
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 28b44ae..fc3035a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+libpam-mklocaluser (0.7) unstable; urgency=low
+
+  * Avoid Popen() problem by throwing away unused output from
+    subprocesses (Closes: #634829).
+
+ -- Petter Reinholdtsen <pere at debian.org>  Tue, 26 Jul 2011 12:48:15 +0200
+
 libpam-mklocaluser (0.6) unstable; urgency=low
 
   * Make module more robust.  Move group lookup into the code path
diff --git a/debian/pam-python.py b/debian/pam-python.py
index 8ba4f05..1b14577 100755
--- a/debian/pam-python.py
+++ b/debian/pam-python.py
@@ -16,8 +16,10 @@ import time
 import syslog
 
 def runcmd(pamh, cmd):
-  proc = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE,)
-  output = proc.communicate()[0]
+  # Throwing away stdout, to avoid crash (race?) reported in #634829
+  # Change to stdout=subprocess.PIPE to collect output.
+  proc = subprocess.Popen(cmd, shell=True, stdout=None,)
+#  output = proc.communicate()[0]
 #  print "output: %s" % output
 
 def check_and_create_localuser(pamh, user):

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debian-edu/upstream/libpam-mklocaluser.git