[Debian-ha-maintainers] Bug#552439: drbd8-source: compilation of the modules give a warning, loading the modules result in a kernel error

[Dr. Tilo Levante]

Package: drbd8-source
Severity: critical
Justification: breaks unrelated software

Installing the modules with 
m-a -t a-b drbd8
gives a warning

  CC [M]  /usr/src/modules/drbd8/drbd/drbd_nl.o
/usr/src/modules/drbd8/drbd/drbd_nl.c: In function ‘drbd_nl_init’:
/usr/src/modules/drbd8/drbd/drbd_nl.c:2380: warning: passing argument 3 of ‘cn_add_callback’ from incompatible pointer type


loading the mopdule results in
[   13.274502] BUG: unable to handle kernel NULL pointer dereference at 0000000000000298
[   13.274691] IP: [<ffffffffa02bf2be>] drbd_connector_callback+0x38/0x18b [drbd]
[   13.274838] PGD 25b5ef067 PUD 25b526067 PMD 0 
[   13.275038] Oops: 0000 [#1] SMP 
[   13.275190] last sysfs file: /sys/module/drbd/parameters/cn_idx
...

reboot does not help.

After loading this gdm did not work properly.
I use vnc4server and gnome-core and gdm and got

WARNING: gdm_slave_xioerror_handler: Fatal X error - Restarting 127.0.0.1:0

The problem results from a feature introduced for 2.6.32. The feature 
was not ifdef-ed.

A patch is included.

diff -Naur x/modules/drbd8/drbd_config.h y/modules/drbd8/drbd_config.h
--- x/modules/drbd8/drbd_config.h	2009-10-26 10:13:28.000000000 +0100
+++ y/modules/drbd8/drbd_config.h	2009-10-16 09:25:44.000000000 +0200
@@ -103,8 +103,6 @@
 
 /* In 2.6.32 we finally fixed connector to pass netlink_skb_parms to the callback
  */
-#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,31)
- #define KERNEL_HAS_CN_SKB_PARMS
-#endif
+#define KERNEL_HAS_CN_SKB_PARMS
 
 #endif


Greetings

Dr. Tilo Levante
tilo at levante.de




-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.29-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash