[Debian-ha-maintainers] Bug#847296: pcs: cluster auth does not generate tokens file & hangs on find

[Rafael David Tinoco]

Package: pcs
Version: 0.9.155-1
Severity: important

I'm working on the following Ubuntu bugs:

https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1580035
https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1580045
https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1640923
https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1640919

And bugs LP: #1640923 and LP: #1640919 should be fixed in Debian.
I'm attaching package debdiffs for both bugs as a fix suggestion.
I'm also proposing the same patch to Zesty, Yakkety & Xenial.

Upstream patch for LP: #1640919 was already accepted:
https://github.com/ClusterLabs/pcs/pull/119

## Problems Description ##

LP: #1640919 - pcs cluster auth does not generate "tokens" file

$ sudo pcs cluster auth cluster01 cluster02 -u hacluster
Password:
cluster01: Authorized
cluster02: Authorized
$ sudo ls -l /var/lib/pcsd/tokens
ls: cannot access '/var/lib/pcsd/tokens': No such file or directory

If corosync and pacemaker are stopped and /etc/corosync.conf is
removed, then /var/lib/pcsd/tokens gets created successfully.

$ systemctl stop pacemaker
$ systemctl stop corosync
$ sudo rm /etc/corosync/corosync.conf
$ sudo pcs cluster auth cluster01 cluster02 -u hacluster
Password:
cluster01: Authorized
cluster02: Authorized

ls -l /var/lib/pcsd/tokens
- -rw------- 1 root root 168 Nov 10 11:54 /var/lib/pcsd/tokens

LP: #1640919 - pcs cluster setup hangs Edit

PCS cluster setup hangs when cleaning up old cluster configurations,
apparently due to a "find" command attempting to search through a
fuse mountpoint directory (/var/lib/lxcfs/*).

$ sudo pcs cluster setup --name cluster cluster01 cluste02
Destroying cluster on nodes: cluster01, cluster02...
cluster01: Stopping Cluster (pacemaker)...
cluster02: Stopping Cluster (pacemaker)...
- ---setup hangs here----

The setup seems to hang because of this line in
/usr/lib/python2.7/dist-packages/pcs/cluster.py (which attempts to
delete stale cluster configuration xml files:

os.system("find /var/lib -name '"+name+"' -exec rm -f \{\} \;")

I'm attaching the fixes soon, following the bug opening.