[Debian-l10n-devel] [Translate-devel] Looking at translate-toolkit 1.10

[Stuart Prescott]

Hi Dwayne,

thanks for taking a look at these issues and for putting each of them into the 
translate-toolkit bugzilla. I was expecting that you'd tell me a couple of 
these things weren't bugs or were completely expected which was why I'd not 
started off in bugzilla. I've added extra details or proposed patches to each 
of the bugs where I have something to share with you at this stage.


> > ** langmodels **
> > 
> > The location of the .lm files in the package is a little mysterious to me
[...]

> On Fedora I've simply moved those to /usr/share, it presents a problem on
> other systems where it makes more sense to contain the data for packaging
> purposes.  So I think translate/share would be the correct behaviour here.

I've taken the approach of using the langmodel files from the libexttextcata-
data package and adding a small patch to translate-toolkit to help it find them 
[0]. I doubt this patch is suited to inclusion in translate-toolkit as-is but 
perhaps we can work on something that is suitable for both bundled and system-
provided files to save us carrying a patch.

[0] http://bugs.locamotion.org/show_bug.cgi?id=2793

> > ** documentation **
[...]

> The default theme is ugly, so rather strip out jquery.

Replacing that jquery.js with a link to the jquery provided by the jquery 
Debian package is enough to get everything in the theme working (just leaving 
out jquery.js from the theme leaves the navigation buttons broken which isn't 
ideal).

As I noted in on IRC the other day, the bootstrap theme is also a bit ugly 
depending on what hardware you've got due to its use of absolute font sizes. 

[1] http://bugs.locamotion.org/show_bug.cgi?id=2808

> The above are coming through when creating the toolkit code
> documentation/API.  If you look in docs/conf.py::Mock you can see modules
> that are faked for doc generation.  Problem is that our code will in some
> cases do a little more testing and then fall back.  So these don't impact
> the actual toolkit. But I didn't get them to the point of removing errors
> from docs generation.

This may be true for some of these errors but is not true for one of them:

$ python2.7 -c 'import translate.misc.xmlwrapper'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "translate/misc/xmlwrapper.py", line 30, in <module>
    basicfixtag = ElementTree.fixtag
AttributeError: 'module' object has no attribute 'fixtag'

(note this works fine with python2.6)

I don't see any errors from this failed import from the test suite -- is there 
no test coverage here or is this module unused on python2.7?

> > ** manpages **
> > 
> > The ManHelpFormatter hasn't quite kept up with the transition to rst. It
> > has
> > always generated some slightly squiffy groff in its hyphens (I've got a
> > patch
> > that I will send you that solves that for options), but it is also now
> > letting
> > through some constructs like "..note" which will leave man very confused.
> > I'll
> > see if there's a way of filtering those to something suitable. I'll
> > forward you
> > some patches as soon as I've got something that isn't reimplementing all
> > of rst2man.
> 
> Much appreciated.

Patches attached to the bug [2]; I expect we'll iterate on them before 
committing anything.

[2] http://bugs.locamotion.org/show_bug.cgi?id=2798


cheers
Stuart

-- 
Stuart Prescott    http://www.nanonanonano.net/   stuart at nanonanonano.net
Debian Developer   http://www.debian.org/         stuart at debian.org
GPG fingerprint    BE65 FD1E F4EA 08F3 23D4 3C6D 9FE8 B8CD 71C5 D1A8
GPG fingerprint    90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7