[Debian-med-packaging] Fwd: Bug#673434: dssp: ftbs with gcc-4.7

[Andreas Tille]

Hi Maarten,

thanks for the preparation.  In principle it is all needed to do
however, the changes compared to the released package are more than just
fixing this bug.  It also contains switching back to dh 7 and a
README.source file which is not documented in changelog.

Please complete the changelog before we sponsor the package.

Side note: We should discuss here how long we should regard Lucid in our
Debian packaging and whether Lucid users rather should use a debhelper
backport.

Kind regards

       Andreas.

On Mon, May 21, 2012 at 10:06:19AM +0200, Maarten L. Hekkelman wrote:
> Hi,
> 
> I added the patch suggested in the bug report to the debian patches
> for dssp. I changed the debian version number and updated the
> changelog and checked in these changes.
> 
> I guess that's all I needed to do, right?
> 
> -maarten
> 
> 
> -------- Originele bericht --------
> Onderwerp: [Debian-med-packaging] Bug#673434: dssp: ftbs with gcc-4.7
> Opnieuw-verstuurd-datum: Fri, 18 May 2012 17:39:02 +0000
> Opnieuw-verstuurd-door: Julian Taylor <jtaylor.debian at googlemail.com>
> Opnieuw-verstuurd-naar: debian-bugs-dist at lists.debian.org
> Opnieuw-verstuurd-CC: Debian Med Packaging Team
> <debian-med-packaging at lists.alioth.debian.org>
> Datum: Fri, 18 May 2012 19:38:06 +0200
> Van: Julian Taylor <jtaylor.debian at googlemail.com>
> Antwoord-naar: Julian Taylor <jtaylor.debian at googlemail.com>,
> 673434 at bugs.debian.org
> Aan: Debian Bug Tracking System <submit at bugs.debian.org>
> 
> Package: dssp
> Version: 2.0.4-1
> Severity: serious
> User: debian-gcc at lists.debian.org
> Usertags: ftbfs-gcc-4.7
> Tags: patch
> 
> dssp fails to build with gcc-4-7 in unstable:
> 
> g++ -MD -c -o obj/utils.o src/utils.cpp -g -O2 -fstack-protector
> --param=ssp-buffer-size=4 -Wformat -Werror=format-security -iquote src
> -g -Wall -Wno-multichar -pthread -O3 -DUSE_COMPRESSION -DLINUX
> -DVERSION='"2.0.4"' -DNDEBUG
> In file included from src/primitives-3d.cpp:17:0:
> src/matrix.h: In instantiation of 'matrix<T> operator-(const
> matrix_base<T>&, const matrix_base<T>&) [with T = double]':
> src/primitives-3d.cpp:336:25:   required from here
> src/matrix.h:313:79: error: 'min' was not declared in this scope, and no
> declarations were found by argument-dependent lookup at the point of
> instantiation [-fpermissive]
> In file included from /usr/include/c++/4.7/algorithm:62:0,
>                  from /usr/include/c++/4.7/valarray:40,
>                  from src/primitives-3d.cpp:10:
> /usr/include/c++/4.7/bits/stl_algobase.h:233:5: note: 'template<class
> _Tp, class _Compare> const _Tp& std::min(const _Tp&, const _Tp&,
> _Compare)' declared here, later in the translation unit
> In file included from src/primitives-3d.cpp:17:0:
> src/matrix.h:313:79: error: 'min' was not declared in this scope, and no
> declarations were found by argument-dependent lookup at the point of
> instantiation [-fpermissive]
> In file included from /usr/include/c++/4.7/algorithm:62:0,
>                  from /usr/include/c++/4.7/valarray:40,
>                  from src/primitives-3d.cpp:10:
> /usr/include/c++/4.7/bits/stl_algobase.h:233:5: note: 'template<class
> _Tp, class _Compare> const _Tp& std::min(const _Tp&, const _Tp&,
> _Compare)' declared here, later in the translation unit
> make[1]: *** [obj/primitives-3d.o] Error 1
> 
> attached a patch fixing the issue.
> 
> 

-- 
http://fam-tille.de