[Debian-med-packaging] Bug#728121:

[Mathieu Malaterre]

Really ?

$ grep -ri find_package elastix-4.6
elastix-4.6/src/CMakeLists.txt:FIND_PACKAGE( ITK REQUIRED )
elastix-4.6/src/CMakeLists.txt:  FIND_PACKAGE( CUDA REQUIRED )
elastix-4.6/src/CMakeLists.txt:FIND_PACKAGE( Doxygen QUIET )
elastix-4.6/.pc/itk-review-detection.patch/src/CMakeLists.txt:FIND_PACKAGE(
ITK REQUIRED )
elastix-4.6/.pc/itk-review-detection.patch/src/CMakeLists.txt:
FIND_PACKAGE( CUDA REQUIRED )
elastix-4.6/.pc/itk-review-detection.patch/src/CMakeLists.txt:FIND_PACKAGE(
Doxygen QUIET )
elastix-4.6/dox/externalproject/CMakeLists.txt:FIND_PACKAGE( ITK REQUIRED )


Your point is correct, importing *solely* ITK 4.0 does work. However
what does not work is clearly indicated at

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=728121#10

This is a ~4 lines demonstration which makes the package unusable for
a lot of us.

As explained in §4.13:

https://www.debian.org/doc/debian-policy/ch-source.html#s-embeddedfiles

"Debian packages should not make use of these convenience copies
unless the included package is explicitly intended to be used in this
way."

You are required to explicitely state why ITK 4.0 package is using
it's convienient GDCM copy.

Thanks for comments,

On 2/8/14, Steve M. Robbins <steve at sumost.ca> wrote:
> On Wed, Jan 29, 2014 at 11:02:35AM +0100, Mathieu Malaterre wrote:
>> Control: severity 728121 grave
>>
>> Marking as grave since render the package unusable.
>
> How does this render the package unusable?  As one counter-example,
> the package 'elastix' builds fine using the ITK -dev package.
>
> -Steve
>


-- 
Mathieu